Notify the user when deleting a superproject

readthedocs/projects/views/private.py

@@ -243,6 +243,11 @@ def project_delete(request, project_slug):
         slug=project_slug,
     )
 
+    context = {
+        'project': project,
+        'is_superproject': project.subprojects.all().exists()
+    }
+
     if request.method == 'POST':
         broadcast(
             type='app',
@@ -254,7 +259,7 @@ def project_delete(request, project_slug):
         project_dashboard = reverse('projects_dashboard')
         return HttpResponseRedirect(project_dashboard)
 
-    return render(request, 'projects/project_delete.html', {'project': project})
+    return render(request, 'projects/project_delete.html', context)
 
 
 class ImportWizardView(ProjectSpamMixin, PrivateViewMixin, SessionWizardView):

readthedocs/rtd_tests/tests/test_project_views.py

@@ -414,6 +414,20 @@ def test_delete_project(self):
                 args=[(project.doc_path,)],
             )
 
+    def test_delete_superproject(self):
+        super_proj = get(Project, slug='pip', users=[self.user])
+        sub_proj = get(Project, slug='test-sub-project', users=[self.user])
+
+        self.assertFalse(super_proj.subprojects.all().exists())
+        super_proj.add_subproject(sub_proj)
+
+        response = self.client.get('/dashboard/pip/delete/')
+        self.assertEqual(response.status_code, 200)
+        self.assertIn(
+            'This project has subprojects under it. Deleting this will make them as regular projects. This will effect the URLs of the subprojects and they will be served normally as other projects.',
+            response.content.decode('utf-8')
+        )
+
     def test_subproject_create(self):
         project = get(Project, slug='pip', users=[self.user])
         subproject = get(Project, users=[self.user])

readthedocs/templates/projects/project_delete.html

@@ -6,6 +6,11 @@
 {% block content-header %}<h1>{% blocktrans with project.name as name %}Delete {{ name }}?{% endblocktrans %}</h1>{% endblock %}
 
 {% block content %}
+
+  {% if is_superproject %}
+    <p>This project has subprojects under it. Deleting this will make them as regular projects. This will effect the URLs of the subprojects and they will be served normally as other projects.</p>
+  {% endif %}
+
   <p>{% trans "You sure?" %} O_o</p>
 
   <form method="post" action=".">{% csrf_token %}