Fix: no highlighting of matched keywords in search results #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dojutsu-user
added
the
PR: work in progress
dojutsu-user
removed
the
PR: work in progress
ericholscher
approved these changes
Jul 26, 2019
There was a problem hiding this comment.
I'm not in love with this, because <em> actually has a display meaning, whereas <span> doesn't. This means if we theme doesn't have a special class for span.highlighted, it won't show up different at all, instead of at least being in italics. I'm not sure the best way to go with this, but I'm 👍 matching Sphinx I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many sphinx themes have highlighting styles for a span tag:
span.highlighted, but elasticsearch uses<em>tag to mark the highlighted results, by default.So results were not getting highlighted with the matched keywords.
Example:
Results:
Related PR: readthedocs/readthedocs-sphinx-search#41