Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search analytics improvements #6050

Merged

Conversation

@dojutsu-user
Copy link
Member

@dojutsu-user dojutsu-user commented Aug 8, 2019

This is a follow up PR from #6019

@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Aug 8, 2019

@ericholscher
I have made the suggested changes.

Not sure if we really even want to cascade these deletes. Is there a reason we don't want to store Version here as a string, so we can keep them forever even if a version is deleted? (comment)

We can definitely do these. But we are keeping nothing for forever -- we delete the old queries every day. So I think that won't be of much benefit?

@dojutsu-user dojutsu-user requested review from ericholscher and Aug 8, 2019
@dojutsu-user
Copy link
Member Author

@dojutsu-user dojutsu-user commented Aug 8, 2019

We do have some queries to optimize if they break in the prod. 🤞

Copy link
Member

@ericholscher ericholscher left a comment

Looks much better 👍

readthedocs/projects/views/base.py Outdated Show resolved Hide resolved
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Aug 8, 2019

Looks good, will ship this out today. 👍

@ericholscher ericholscher merged commit df17d9d into readthedocs:master Aug 8, 2019
1 check passed
@dojutsu-user dojutsu-user deleted the search-analytics-improvements branch Aug 8, 2019
@dojutsu-user dojutsu-user added this to In progress in In-doc search UI via automation Aug 9, 2019
@dojutsu-user dojutsu-user moved this from In progress to Done in In-doc search UI Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants