Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete .cache dir on wipe #6571

Merged
merged 1 commit into from Jan 23, 2020
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 22, 2020

We are not deleting this directory, here is where PIP caches its
packages.

@property
def pip_cache_path(self):
"""Path to pip cache."""
return os.path.join(self.doc_path, '.cache', 'pip')

Users can still get the old (buggy) PIP version because of this.

But why wiping worked for a lot of people?

Because after wiping, we recreate the virtual environment and looks like
PIP doesn't use the packages from the cache.
But in the next build, when reusing the virtual environment, it will use
the packages from the cache.

ref #6554 (comment)

We are not deleting this directory, here is where PIP caches its
packages.

Users can still get the old (buggy) PIP version because of this.

But why wiping worked for a lot of people?

Because after wiping, we recreate the virtual environment and looks like
PIP  doesn't use the packages from the cache.
But in the next build, when reusing the virtual environment, it will use
the packages from the cache.
@stsewd
Copy link
Member Author

stsewd commented Jan 22, 2020

May fix #5810

@stsewd stsewd mentioned this pull request Jan 22, 2020
@stsewd
Copy link
Member Author

stsewd commented Jan 22, 2020

Also, this is why we didn't remove it before #5685

@Aricg
Copy link

Aricg commented Jan 23, 2020

Thanks guys!

@stsewd stsewd merged commit 48ec2c0 into readthedocs:master Jan 23, 2020
@stsewd stsewd deleted the delete-cache-dir-on-wipe branch January 23, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants