Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alter field url on webhook #6988

Merged
merged 2 commits into from
May 4, 2020
Merged

Alter field url on webhook #6988

merged 2 commits into from
May 4, 2020

Conversation

santos22
Copy link
Contributor

@santos22 santos22 commented Apr 29, 2020 •
edited
Loading

See #6625

Went with the option to explicitly ask users to use http or https schemes

Removed custom URL validator in favor of the built-in Django one.

Ran migration with the following command:

 python manage.py makemigrations --name webhook_url_set_blank_default projects

Also cleaned up some class names that were misspelled!

@santos22 santos22 requested review from humitos and stsewd April 30, 2020 03:32
@santos22 santos22 changed the title Require https for webhook URLs Require http or https scheme for webhook URLs Apr 30, 2020
@santos22 santos22 changed the title Require http or https scheme for webhook URLs Default blank option to False for webhook URLs May 1, 2020
@santos22 santos22 changed the title Default blank option to False for webhook URLs Alter field url on webhook May 1, 2020
stsewd
stsewd approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing the fix wasn't needed 👍

@stsewd stsewd merged commit a53e9e2 into readthedocs:master May 4, 2020
@stsewd stsewd mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

@humitos humitos Awaiting requested review from humitos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santos22 @humitos @stsewd