Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter field url on webhook #6988

Merged
merged 2 commits into from May 4, 2020
Merged

Alter field url on webhook #6988

merged 2 commits into from May 4, 2020

Conversation

santos22
Copy link
Contributor

@santos22 santos22 commented Apr 29, 2020

See #6625

Went with the option to explicitly ask users to use http or https schemes

Removed custom URL validator in favor of the built-in Django one.

Ran migration with the following command:

 python manage.py makemigrations --name webhook_url_set_blank_default projects

Also cleaned up some class names that were misspelled!

readthedocs/projects/forms.py Outdated Show resolved Hide resolved
readthedocs/projects/forms.py Outdated Show resolved Hide resolved
@santos22 santos22 requested review from humitos and stsewd Apr 30, 2020
@santos22 santos22 changed the title Require https for webhook URLs Require http or https scheme for webhook URLs Apr 30, 2020
@santos22 santos22 changed the title Require http or https scheme for webhook URLs Default blank option to False for webhook URLs May 1, 2020
@santos22 santos22 changed the title Default blank option to False for webhook URLs Alter field url on webhook May 1, 2020
stsewd
stsewd approved these changes May 4, 2020
Copy link
Member

@stsewd stsewd left a comment

Thanks for noticing the fix wasn't needed 👍

@stsewd stsewd merged commit a53e9e2 into readthedocs:master May 4, 2020
2 checks passed
@stsewd stsewd mentioned this pull request May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants