Tests: mock trigger build to speed up tests #7661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise trigger_build would try to call the API, and then keep trying till it times out. In these tests we don't need to run trigger_build.
humitos
approved these changes
Nov 17, 2020
stsewd
added a commit
that referenced
this pull request
Nov 18, 2020
Noticed these slow tests today. Otherwise it will keep retrying till it times out. Similar to #7661
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise trigger_build would try to call the API,
and then keep trying till it times out.
In these tests we don't need to run trigger_build. This was more noticeable in the automation rules tests, bc they are a lot and almost each tests call to trigger build :D. Probably there are other tests that are hitting this code, but those were the ones I found so far