Make Build models default to triggered

[ericholscher]

I'm not sure why we were defaulting them to Finished,
but this should help not confuse the badge code,
and just be more correct in general.

[stsewd]

Looks like tests need to be updated, this also discovered a bug (just a missing none check) :D

btw, we already change the value to triggered

readthedocs.org/readthedocs/core/utils/__init__.py

Lines 118 to 125 in 655a34a

	build = Build.objects.create(
	project=project,
	version=version,
	type='html',
	state=BUILD_STATE_TRIGGERED,
	success=True,
	commit=commit
	)

but better to have it by default.

[humitos]

@ericholscher it would be good to finish this PR and merge it when you have some time. It seems there is some tests failing due to the change.

[ericholscher]

@humitos feel free to finish it up if you have bandwidth. I don't think I'll have time for a little while, unfortunately.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[humitos]

I'm adding this PR to the Roadmap Q3 so we can finish it. It would be good to have our data being consistent.

[humitos]

@stsewd would you like (if you have some time 😄 ) to take a look at this PR and update it so we can move forward and merge it? 🙏🏼

[stsewd]

Did a quick test locally, I didn't see anything weird.

[ericholscher]

👍 Can't approve this since I originally opened it, but looks great. Thanks for pushing this to done!