Search: show only results from the current role_name being filtered #8454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Aug 31, 2021
| blocks = first_result['blocks'] | ||
| for block in blocks: | ||
| assert block['type'] == 'domain' | ||
| assert block['role'] == confval_facet |
There was a problem hiding this comment.
this test fails without this change, previously we were checking if the first block was py:class, but the second block was py:function...
ericholscher
approved these changes
Sep 1, 2021
Comment on lines
+373
to
+374
| # TODO: We should use a flattened document instead | ||
| # to avoid this kind of problems and have faster queries. |
There was a problem hiding this comment.
Yea, I feel like we've mentioned this a number of times. Really should figure it out at some point. Is this tracked in an issue or roadmap card anywhere?
There was a problem hiding this comment.
I'll create a new issue and add it for a future task in our roadmap 👍
There was a problem hiding this comment.
Done #8457, I put a card on the "Needs discussion" column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR; show only domains that match the selected role_name.
before
there are
http:getroles mixed withhttp:post(mixed with results from top docs)now
there are only domains with
http:postin the results (mixed with results from top docs)Long version, see the comment in the code and #8268 (comment).
Closes #8268