Build: do not upload build.tool to production S3
#9098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid uploading the .tar.gz to production S3 since we will be managing this via CircleCI and an AWS orbs. See readthedocs/readthedocs-docker-images#179 We need to keep the upload part for development environment, tho.
humitos
force-pushed
the
humitos/build-tool-no-upload-production
branch
from
167b14d
to
337c36b
Compare
We are not going to run this command in production by hand anymore. However, in case it's required, I'm linking to the issue that explains how to do it.
…ut date" This reverts commit e08a7de.
humitos
commented
Apr 13, 2022
agjohnson
approved these changes
Apr 14, 2022
| AWS_SECRET_ACCESS_KEY="${AWS_SECRET_ACCESS_KEY:-password}" | ||
|
|
||
| if [[ -z $AWS_REGION ]] | ||
| if [[ -z $CIRCLECI ]] |
There was a problem hiding this comment.
I noticed this on the shell scripting on the ops side of this change as well, and a few spots above, but just to note: when using variables in sh/bash, it's best to quote them:
https://tldp.org/LDP/abs/html/quotingvar.html
We don't expect are any problematic characters in these variables, so this isn't an issue.
I've definitely been bit by unquoted variables in the past, usually around string comparisons.
Suggested change
| if [[ -z $CIRCLECI ]] | |
| if [[ -z "$CIRCLECI" ]] |
|
Failure is docs, merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid uploading the .tar.gz to production S3 since we will be managing this via
CircleCI and an AWS orbs. See
readthedocs/readthedocs-docker-images#179
We need to keep the upload part for development environment, tho.