Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds: fix retry #9133

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Builds: fix retry #9133

merged 2 commits into from
Apr 25, 2022

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Apr 22, 2022

autoretry_for is broken,
using plain self.retry with a custom exception
works.

autoretry_for is broken,
using plain self.retry with a custom exception
works.
@stsewd stsewd requested a review from a team as a code owner April 22, 2022 01:09
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't test this change, but I think a good way to test it in production could be to change the code in one instance and route builds from test-builds to that particular instance to make sure this works.

Besides, if we are not going to use autoretry_for, we should explain why we are not using it anymore in a code comment to avoid hitting the same problem. The documentation says that autoretry_for is the "syntax sugar way" when using Celery handlers. I missed the part of that comment in the review.

@stsewd stsewd enabled auto-merge (squash) April 25, 2022 22:23
@stsewd stsewd merged commit a4d579e into main Apr 25, 2022
@stsewd stsewd deleted the fix-retry-take2 branch April 25, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants