Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: use backtracking pip's resolver #9821

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Dec 19, 2022

Upgrade the resolver to avoid conflicts while resolving dependencies.
The GHA has been failing in the last 2 week because of this issue. Hopefully,
by using the new resolver we can fix it.

Solves: https://github.com/readthedocs/readthedocs.org/actions/runs/3722354255

Upgrade the resolver to avoid conflicts while resolving dependencies.
The GHA has been failing in the last 2 week because of this issue. Hopefully,
by using the new resolver we can fix it.
@humitos humitos requested a review from a team as a code owner December 19, 2022 10:28
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'm always a little scared about dependency updates, especially so many at once 🙃

@@ -50,16 +50,13 @@ six==1.16.0
# via asttokens
stack-data==0.6.2
# via ipython
toml==0.10.2
tomli==2.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ipdb installs toml or tomli depending on other dependencies: https://github.com/gotcha/ipdb/blob/master/setup.py#L66

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting.

@humitos humitos merged commit da7e608 into main Dec 20, 2022
@humitos humitos deleted the humitos/pip-tools-resolver branch December 20, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants