Proxito: always check 404/index.hmtml
#9983
Conversation
With the introduction of `build.commands` we cannot use `version.documentation_type` anymore since those versions will be `generic` and we can't skip checking for this file location. Note this commit may add and extra call to S3 API for all the 404 pages where our regular Maze will be shown. However, it removes 2 databsae calls from all the 404 requests. We could only add this extra check on S3 for `version.documentation_type='generic'`, but that would make the code a little more complex and we won't be removing these 2 db queries. Reference: readthedocs/sphinx-notfound-page#215 (comment)
There was a problem hiding this comment.
Note this commit may add and extra call to S3 API for all the 404 pages where our regular Maze will be shown. However, it removes 2 databsae calls from all the 404 requests.
Can you explain this a bit more? I don't see the 2 removals.
Overall this is the right approach. Let's just serve what is on the filesystem at either reasonable path, and not try to be magical here.
Do we need to update the docs to note that secondary location?
We are removing the db queries to know the
Yes. Good point. |
I'm interested in `README.html` since we should probably deprecate that "feature"
|
Oh, database calls, not S3 calls :) That makes more sense. |
|
Also @benjaoming, note the docs update here. Another point for getting our branch merged into main so we can stop diverging. |
|
oh there's been quite a lot of those already, I merge |
|
Two steps ahead! :) |
|
Wow, no conflicts. Very elegant @humitos 😍 |
With the introduction of
build.commandswe cannot useversion.documentation_typeanymore since those versions will begenericand we can't skip checking for this file location.Note this commit may add and extra call to S3 API for all the 404 pages where our regular Maze will be shown. However, it removes 2 databsae calls from all the 404 requests.
We could only add this extra check on S3 for
version.documentation_type='generic', but that would make the code a little more complex and we won't be removing these 2 db queries.Reference: readthedocs/sphinx-notfound-page#215 (comment)