Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/interrupt should allow specifying prompt_id #5

Open
realazthat opened this issue Jan 16, 2024 · 1 comment
Open

/interrupt should allow specifying prompt_id #5

realazthat opened this issue Jan 16, 2024 · 1 comment
Assignees
@realazthat

Comments

@realazthat
Copy link
Owner

realazthat commented Jan 16, 2024 •
edited
Loading

The post /interrupt endpoint allows clearing the current running node. However, a race condition might result in it cancelling the wrong job. The PostInterrupt() should take a prompt_id to ensure it will cancel the correct job only.

See api_client_base.py:

comfy-catapult/comfy_catapult/api_client_base.py

Line 128 in 2a72ebb

async def PostInterrupt(self):

See server.py:

https://github.com/comfyanonymous/ComfyUI/blob/ee2c5fa72d4fc1714576fac7ba64aa5d607303d0/server.py#L507

Blocked on: comfyanonymous/ComfyUI#2566
@realazthat realazthat self-assigned this Jan 16, 2024
@realazthat
Copy link
Owner Author

PR: comfyanonymous/ComfyUI#2857

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@realazthat realazthat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@realazthat