Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if no violations were produced in a disabled region #1102

Closed
jpsim opened this issue Dec 31, 2016 · 2 comments
Closed

Warn if no violations were produced in a disabled region #1102

jpsim opened this issue Dec 31, 2016 · 2 comments
Labels
enhancement Ideas for improvements of existing features and rules.

Comments

@jpsim
Copy link
Collaborator

jpsim commented Dec 31, 2016

Maybe SwiftLint should warn if a disable command doesn't actually silence a violation?

Due to SwiftLint's architecture, we already detect these violations, we just filter them out (silence them) if they happen to be in a disabled region before passing it back to the linter.

So it shouldn't be too hard to do this.

@jpsim jpsim added the enhancement Ideas for improvements of existing features and rules. label Dec 31, 2016
@heidiproske
Copy link

❤ yes please! I recently did this (manually) and was able to remove a bunch of unnecessary disable flags. (The project had been refactored and Linting had been disabled for a while so things became out of date.)

@marcelofabri
Copy link
Collaborator

Closed in #1740.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Ideas for improvements of existing features and rules.
Projects
None yet
Development

No branches or pull requests

3 participants