Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validates_start_with_lowercase on identifier_name configuration doesn't work #1626

Closed
ArthurMaroulier opened this issue Jun 16, 2017 · 3 comments
Labels
bug Unexpected and reproducible misbehavior.

Comments

@ArthurMaroulier
Copy link

ArthurMaroulier commented Jun 16, 2017

Hello, I run SwiftLint 0.19.0 as a pod in xcode 8.3.3.
I've added configurations for the identifier_name rule in my yaml file:

identifier_name:
  min_length: 2
  validates_start_with_lowercase: false

min_length configuration works but validates_start_with_lowercase configuration don't.

I saw in the releases that validates_start_with_lowercase as opt-in configuration was added as an enhancement in v0.19.0.

Is my configuration wrong ?
Is somebody else have the same problem ?

For example, SwiftLint triggers the validates_start_with_lowercase error on:

enum Cache {
    case User
    case Shared
    case Public
}

Thanks

@marcelofabri
Copy link
Collaborator

Err, the key is actually wrong in the implementation: we print validates_start_with_lowercase in the description, but use validates_start_lowercase to read.

Could you try using validates_start_lowercase just to check if that's the only issue?

@ArthurMaroulier
Copy link
Author

Hello, I've checked with v0.20.0, it works now, thanks for your reactivity.

@marcelofabri
Copy link
Collaborator

@ArthurMaroulier thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected and reproducible misbehavior.
Projects
None yet
Development

No branches or pull requests

2 participants