New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error message when using `max_empty_lines` with rule `vertical_whitespace` #1763

Closed
hossamghareeb opened this Issue Aug 10, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@hossamghareeb
Contributor

hossamghareeb commented Aug 10, 2017

Hello,
My swiftlint file is configured like:

vertical_whitespace:
  max_empty_lines: 2

and it works fine but the warning message is wrong. So instead of saying warning: Vertical Whitespace Violation: Limit vertical whitespace to a single empty line. Currently 4. (vertical_whitespace) it should say warning: Vertical Whitespace Violation: Limit vertical whitespace to 2 empty lines. Currently 4. (vertical_whitespace)

@marcelofabri marcelofabri added the bug label Aug 10, 2017

@marcelofabri

This comment has been minimized.

Show comment
Hide comment
@marcelofabri

marcelofabri Aug 10, 2017

Collaborator

Thanks for filling this issue, @hossamghareeb! Would you like to send a PR fixing this? 💯

Collaborator

marcelofabri commented Aug 10, 2017

Thanks for filling this issue, @hossamghareeb! Would you like to send a PR fixing this? 💯

@hossamghareeb

This comment has been minimized.

Show comment
Hide comment
@hossamghareeb

hossamghareeb Aug 10, 2017

Contributor

Yeah sure, I've forked the project and will work on it. I think the auto correction as well would need fixing, as it corrects to one single line instead of the max_empty_lines

Contributor

hossamghareeb commented Aug 10, 2017

Yeah sure, I've forked the project and will work on it. I think the auto correction as well would need fixing, as it corrects to one single line instead of the max_empty_lines

@marcelofabri

This comment has been minimized.

Show comment
Hide comment
@marcelofabri

marcelofabri Aug 14, 2017

Collaborator

Closed in #1774.

Collaborator

marcelofabri commented Aug 14, 2017

Closed in #1774.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment