New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule request: fallthrough should be avoided #1834

Closed
marcelofabri opened this Issue Sep 11, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@marcelofabri
Collaborator

marcelofabri commented Sep 11, 2017

New Issue Checklist

Rule Request

Avoid fallthrough inside switch statements.

  1. Why should this rule be added? Share links to existing discussion about what
    the community thinks about this.

Using fallthrough makes code harder to read and, in most cases, can be replaced by combining cases. LinkedIn's Swift Style Guide also thinks that (item 3.4.5).

  1. Provide several examples of what would and wouldn't trigger violations.
// should trigger
switch foo {
case .bar:
    fallthrough
case .bar2:
    fallthrough
case .bar3
    something()
}


// shouldn't trigger
switch foo {
case .bar, .bar2, .bar3:
    something()
}
  1. Should the rule be configurable, if so what parameters should be configurable?

Only severity.

  1. Should the rule be opt-in or enabled by default? Why?
    See README.md for guidelines on when to mark a rule as opt-in.

Opt-in. In the end, this is still a matter of style and there are situations where you can't just combine cases.

marcelofabri added a commit to marcelofabri/SwiftLint that referenced this issue Sep 11, 2017

marcelofabri added a commit to marcelofabri/SwiftLint that referenced this issue Sep 11, 2017

@Sega-Zero Sega-Zero referenced this issue Oct 7, 2017

Closed

fallthrough false positive #1892

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment