Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwanted closing_brace violation warning #592

Closed
toshi0383 opened this issue Mar 24, 2016 · 1 comment
Closed

Unwanted closing_brace violation warning #592

toshi0383 opened this issue Mar 24, 2016 · 1 comment
Labels
bug Unexpected and reproducible misbehavior.

Comments

@toshi0383
Copy link
Contributor

I believe this is unwanted behavior of closing_brace rule.

$ cat AnimationBlock.swift
UIView.animateWithDuration(
    0.2,
    animations: {
        self.layoutIfNeeded()
        self.underline.show()
    },
    completion: {
        _ in
        completion()
    }
)
$ swiftlint lint --path AnimationBlock.swift
Loading configuration from '.swiftlint.yml'
Linting Swift files at path AnimationBlock.swift
Linting 'AnimationBlock.swift' (1/1)
/Users/toshi0383/dvideo/tv/app/AnimationBlock.swift:9:5: warning: Closing Brace Spacing Violation: Closing brace with closing parenthesis should not have any whitespaces in the middle. (closing_brace)
Done linting! Found 1 violation, 0 serious in 1 file.
$ swiftlint version
0.9.2
@nhgrif
Copy link

nhgrif commented Mar 25, 2016

I agree. I believe the code there looks correct to me and don't like swiftlint moving the parenthesis up onto the line with the closing brace (and indented).

@norio-nomura norio-nomura added the bug Unexpected and reproducible misbehavior. label Mar 25, 2016
joshfriend pushed a commit to joshfriend/SwiftLint that referenced this issue Apr 5, 2016
joshfriend pushed a commit to joshfriend/SwiftLint that referenced this issue Apr 5, 2016
@jpsim jpsim closed this as completed in #605 Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected and reproducible misbehavior.
Projects
None yet
Development

No branches or pull requests

3 participants