Allow displaying only enabled rules in RulesCommand #1275

natanrolnik · 2017-02-02T10:54:07Z

See #1270.
I've also updated the Commandant submodule to include the fix for Switches included in this PR.

SwiftLintBot · 2017-02-02T11:10:04Z

	3 Warnings
⚠️	This PR may need tests.
⚠️	This PR introduced a violation in ios-oss: /Kickstarter-iOS/Views/Cells/RewardCell.swift#L57:31: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
⚠️	This PR introduced a violation in ios-oss: /Library/Paginate.swift#L51:3: error: Large Tuple Violation: Tuples should have at most 3 members. (large_tuple)

	13 Messages
📖	Linting WordPress-iOS with this PR took 17.8s vs 20.53s on master (13% faster)
📖	Linting Alamofire with this PR took 3.66s vs 4.79s on master (23% faster)
📖	Linting swift with this PR took 13.25s vs 17.46s on master (24% faster)
📖	Linting Aerial with this PR took 0.49s vs 0.68s on master (27% faster)
📖	Linting SourceKitten with this PR took 1.44s vs 1.91s on master (24% faster)
📖	Linting Sourcery with this PR took 2.82s vs 3.51s on master (19% faster)
📖	This PR fixed a violation in ios-oss: /Library/Paginate.swift#L51:3: warning: Large Tuple Violation: Tuples should have at most 2 members. (large_tuple)
📖	Linting Moya with this PR took 0.58s vs 0.59s on master (1% faster)
📖	Linting firefox-ios with this PR took 25.07s vs 27.76s on master (9% faster)
📖	Linting Nimble with this PR took 2.59s vs 3.16s on master (18% faster)
📖	Linting Quick with this PR took 0.81s vs 0.93s on master (12% faster)
📖	Linting realm-cocoa with this PR took 4.29s vs 4.9s on master (12% faster)
📖	Linting ios-oss with this PR took 21.28s vs 23.34s on master (8% faster)

Generated by 🚫 danger

natanrolnik · 2017-02-02T15:13:11Z

Currently, swiftlint rules --enabled doesn't work the same way as swiftlint rules -e due to a bug in Commandant. I've submitted a PR to fix it there.

marcelofabri · 2017-02-02T22:57:30Z

CHANGELOG.md

@@ -23,6 +23,10 @@
  [Marcelo Fabri](https://github.com/marcelofabri)
  [#1061](https://github.com/realm/SwiftLint/issues/1061)

+* Allow displaying only enabled rules in `RulesCommand`.


this is missing two trailing whitespaces

marcelofabri · 2017-02-02T22:57:40Z

Source/swiftlint/Commands/RulesCommand.swift

        return .success()
    }
+
+    func ruleList(for options: RulesOptions, configuration: Configuration) -> RuleList {


this should be private

marcelofabri · 2017-02-02T22:58:04Z

Source/swiftlint/Commands/RulesCommand.swift

-        return { ruleID in
-            self.init(ruleID: (ruleID.isEmpty ? nil : ruleID), configurationFile: configurationFile)
-        }
+    // swiftlint:disable line_length


you can use swiftlint:disable:next line_length instead

Cool, will change that

marcelofabri · 2017-02-02T22:58:47Z

Source/swiftlint/Commands/RulesCommand.swift

    static func evaluate(_ mode: CommandMode) -> Result<RulesOptions, CommandantError<CommandantError<()>>> {
        return create
            <*> mode <| configOption
            <*> mode <| Argument(defaultValue: "",
                                 usage: "the rule identifier to display description for")
+            <*> mode <| Switch(flag: Character("e"),


can't you just use "e"?. I expected this to work because of StringLiteralConvertible.

natanrolnik · 2017-02-05T11:04:10Z

@marcelofabri fixed all your comments. Also, why are the trailing whitespaces needed at the end of each issue line in the Changelog?

codecov-io · 2017-02-08T00:44:44Z

Codecov Report

❗ No coverage uploaded for pull request base (master@3f6d528). Click here to learn what that means.

@@            Coverage Diff            @@
##             master    #1275   +/-   ##
=========================================
  Coverage          ?   81.75%           
=========================================
  Files             ?      168           
  Lines             ?     8363           
  Branches          ?        0           
=========================================
  Hits              ?     6837           
  Misses            ?     1526           
  Partials          ?        0

Impacted Files	Coverage Δ
Source/swiftlint/Commands/RulesCommand.swift	`0% <ø> (ø)`
...rce/SwiftLintFramework/Models/MasterRuleList.swift	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6d528...c81bcc1. Read the comment docs.

norio-nomura

Could you please update Cartfile* to reflect changes of Carthage/Checkouts/Commandant?
The steps would be:

Edit Cartfile.private to use master of Commandant
carthage update Commandant --no-build

Fixes realm#1161

…ocol.

Using `git clean -qdf` removes bundler folder

See https://medium.com/zendesk-engineering/running-a-child-process-in-ruby-properly-febd0a2b6ec8#.p5a2j1d9l

natanrolnik · 2017-02-08T08:42:40Z

@norio-nomura @marcelofabri I've made the changes you requested.
I had a hard time rebasing this branch/PR, so I've reopened as #1293

natanrolnik mentioned this pull request Feb 2, 2017

Allow filtering of rules in rules command #1270

Closed

natanrolnik force-pushed the filter-enabled-rules branch 2 times, most recently from 7986fc7 to 369ccfa Compare February 2, 2017 11:08

natanrolnik force-pushed the filter-enabled-rules branch from 369ccfa to fe022c7 Compare February 2, 2017 11:24

marcelofabri requested changes Feb 2, 2017

View reviewed changes

natanrolnik force-pushed the filter-enabled-rules branch from fe022c7 to f2bdd11 Compare February 5, 2017 11:02

natanrolnik force-pushed the filter-enabled-rules branch 3 times, most recently from 6ef8ac2 to c81bcc1 Compare February 5, 2017 15:03

norio-nomura requested changes Feb 8, 2017

View reviewed changes

marcelofabri and others added 16 commits February 8, 2017 10:12

Ignore unused_closure_parameter on inline closures

ecec105

Fixes realm#1161

Update ClassDelegateProtocolRule to accept AnyObject and NSObjectProt…

7ad5e90

…ocol.

Update CHANGELOG.

b68e17f

Update implementation and CHANGELOG markdown.

c884387

Small refactoring

a7d29c0

Add oss-check script

649b8fa

Make Danger use the script

4de3993

Use stderr

d89259c

Run script with a clean env

af49913

Always use Xcode reporter on oss-check

7cabda3

Fix cleanup

cff52af

Using `git clean -qdf` removes bundler folder

Fix links

a1c1dfa

small Danger/oss-check improvements

5fb6457

Fix deadlock when stderr fills up OS buffer

4b97998

See https://medium.com/zendesk-engineering/running-a-child-process-in-ruby-properly-febd0a2b6ec8#.p5a2j1d9l

disable docs rules in Swift 2.3 and later

a772cc4

fix wording in changelog

2ea6d4e

natanrolnik added 2 commits February 8, 2017 10:12

Allow displaying only enabled rules in RulesCommand

b623cba

Update Commandant

c0dc1b5

natanrolnik force-pushed the filter-enabled-rules branch from 575e555 to c0dc1b5 Compare February 8, 2017 08:12

natanrolnik mentioned this pull request Feb 8, 2017

Allow displaying only enabled rules in RulesCommand #1293

Merged

natanrolnik closed this Feb 8, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow displaying only enabled rules in RulesCommand #1275

Allow displaying only enabled rules in RulesCommand #1275

natanrolnik commented Feb 2, 2017 •

edited

Loading

SwiftLintBot commented Feb 2, 2017 •

edited

Loading

natanrolnik commented Feb 2, 2017 •

edited

Loading

marcelofabri Feb 2, 2017

marcelofabri Feb 2, 2017

marcelofabri Feb 2, 2017

natanrolnik Feb 2, 2017

marcelofabri Feb 2, 2017

natanrolnik Feb 2, 2017

natanrolnik commented Feb 5, 2017

codecov-io commented Feb 8, 2017

norio-nomura left a comment

natanrolnik commented Feb 8, 2017

Allow displaying only enabled rules in RulesCommand #1275

Allow displaying only enabled rules in RulesCommand #1275

Conversation

natanrolnik commented Feb 2, 2017 • edited Loading

SwiftLintBot commented Feb 2, 2017 • edited Loading

natanrolnik commented Feb 2, 2017 • edited Loading

marcelofabri Feb 2, 2017

Choose a reason for hiding this comment

marcelofabri Feb 2, 2017

Choose a reason for hiding this comment

marcelofabri Feb 2, 2017

Choose a reason for hiding this comment

natanrolnik Feb 2, 2017

Choose a reason for hiding this comment

marcelofabri Feb 2, 2017

Choose a reason for hiding this comment

natanrolnik Feb 2, 2017

Choose a reason for hiding this comment

natanrolnik commented Feb 5, 2017

codecov-io commented Feb 8, 2017

Codecov Report

norio-nomura left a comment

Choose a reason for hiding this comment

natanrolnik commented Feb 8, 2017

natanrolnik commented Feb 2, 2017 •

edited

Loading

SwiftLintBot commented Feb 2, 2017 •

edited

Loading

natanrolnik commented Feb 2, 2017 •

edited

Loading