Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unneeded_break_in_switch rule #1872

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Add unneeded_break_in_switch rule #1872

merged 1 commit into from
Oct 2, 2017

Conversation

marcelofabri
Copy link
Collaborator

Fixes #1870

@SwiftLintBot
Copy link

SwiftLintBot commented Oct 1, 2017

137 Warnings
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Account/FirefoxAccount.swift:235:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Account/FirefoxAccount.swift:238:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Application/AppDelegate.swift:413:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Application/AppDelegate.swift:636:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Application/AppDelegate.swift:639:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/BookmarksPanel.swift:106:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/BookmarksPanel.swift:110:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/BookmarksPanel.swift:317:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/BookmarksPanel.swift:335:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/HistoryPanel.swift:136:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/HistoryPanel.swift:143:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/HistoryPanel.swift:147:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/ReaderPanel.swift:242:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/ReaderPanel.swift:249:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/ReaderPanel.swift:253:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/RemoteTabsPanel.swift:104:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Home/RemoteTabsPanel.swift:108:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Reader/ReaderMode.swift:276:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Reader/ReaderMode.swift:281:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Reader/ReaderModeStyleViewController.swift:226:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Reader/ReaderModeStyleViewController.swift:229:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Settings/AppSettingsOptions.swift:403:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Settings/AppSettingsOptions.swift:406:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Client/Frontend/Settings/AppSettingsOptions.swift:409:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Extensions/NotificationService/NotificationService.swift:86:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Extensions/NotificationService/NotificationService.swift:101:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Storage/Bookmarks/BookmarksModel.swift:372:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Storage/Bookmarks/BookmarksModel.swift:375:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Storage/Bookmarks/BookmarksModel.swift:378:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Storage/Logins.swift:494:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Storage/Logins.swift:497:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Storage/Logins.swift:500:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Storage/Logins.swift:503:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Storage/Logins.swift:506:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Storage/Logins.swift:509:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Storage/Logins.swift:512:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Storage/Logins.swift:515:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Storage/Logins.swift:523:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Storage/Logins.swift:526:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Firefox: /Users/distiller/SwiftLint/osscheck/Firefox/Sync/Synchronizers/Bookmarks/BookmarksRepairRequestor.swift:381:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Realm: /Users/distiller/SwiftLint/osscheck/Realm/RealmSwift/Tests/RealmCollectionTypeTests.swift:503:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Realm: /Users/distiller/SwiftLint/osscheck/Realm/RealmSwift/Tests/RealmCollectionTypeTests.swift:506:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Realm: /Users/distiller/SwiftLint/osscheck/Realm/RealmSwift/Tests/RealmCollectionTypeTests.swift:509:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Realm: /Users/distiller/SwiftLint/osscheck/Realm/RealmSwift/Tests/RealmCollectionTypeTests.swift:624:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Realm: /Users/distiller/SwiftLint/osscheck/Realm/RealmSwift/Tests/RealmCollectionTypeTests.swift:628:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Realm: /Users/distiller/SwiftLint/osscheck/Realm/RealmSwift/Tests/RealmCollectionTypeTests.swift:631:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Realm: /Users/distiller/SwiftLint/osscheck/Realm/RealmSwift/Tests/RealmCollectionTypeTests.swift:655:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Realm: /Users/distiller/SwiftLint/osscheck/Realm/RealmSwift/Tests/RealmCollectionTypeTests.swift:662:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Realm: /Users/distiller/SwiftLint/osscheck/Realm/RealmSwift/Tests/RealmCollectionTypeTests.swift:665:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Realm: /Users/distiller/SwiftLint/osscheck/Realm/RealmSwift/Tests/RealmCollectionTypeTests.swift:810:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Realm: /Users/distiller/SwiftLint/osscheck/Realm/RealmSwift/Tests/RealmCollectionTypeTests.swift:813:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Realm: /Users/distiller/SwiftLint/osscheck/Realm/RealmSwift/Tests/RealmCollectionTypeTests.swift:816:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/core/InputStream.swift:59:9: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/core/InputStream.swift:62:9: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/core/KeyPath.swift:2420:7: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:42:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:45:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:48:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:51:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:77:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:80:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:83:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:86:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:99:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:102:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:105:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:107:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:115:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:118:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:121:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:123:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:131:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:134:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:137:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:139:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:147:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:150:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:153:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:155:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:168:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:171:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:174:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:176:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:184:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:187:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:189:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:197:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:199:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:202:17: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:211:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:226:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:230:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:238:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:243:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:306:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:315:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:318:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:321:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:332:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:335:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:338:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:350:29: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:353:29: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:356:29: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:358:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:363:29: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:366:29: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:369:29: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:372:29: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:374:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:377:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:382:29: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:385:29: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:388:29: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:392:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:399:29: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:402:29: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:406:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:418:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:422:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:425:25: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/IndexPath.swift:428:21: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/Data.swift:287:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in Swift: /Users/distiller/SwiftLint/osscheck/Swift/stdlib/public/SDK/Foundation/Data.swift:290:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/Utility/PingHubManager.swift:153:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ This PR introduced a violation in WordPress: /Users/distiller/SwiftLint/osscheck/WordPress/WordPress/Classes/ViewRelated/NUX/SignupViewController.swift:371:13: warning: Unneeded Break in Switch Violation: Avoid using unneeded break statements. (unneeded_break_in_switch)
⚠️ Danger found 137 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 126.
12 Messages
📖 Linting Aerial with this PR took 0.38s vs 0.36s on master (5% slower)
📖 Linting Alamofire with this PR took 2.58s vs 2.55s on master (1% slower)
📖 Linting Firefox with this PR took 10.38s vs 10.41s on master (0% faster)
📖 Linting Kickstarter with this PR took 16.43s vs 16.24s on master (1% slower)
📖 Linting Moya with this PR took 1.25s vs 1.23s on master (1% slower)
📖 Linting Nimble with this PR took 1.54s vs 1.53s on master (0% slower)
📖 Linting Quick with this PR took 0.48s vs 0.47s on master (2% slower)
📖 Linting Realm with this PR took 2.36s vs 2.33s on master (1% slower)
📖 Linting SourceKitten with this PR took 0.88s vs 0.87s on master (1% slower)
📖 Linting Sourcery with this PR took 3.9s vs 3.88s on master (0% slower)
📖 Linting Swift with this PR took 11.2s vs 11.23s on master (0% faster)
📖 Linting WordPress with this PR took 9.91s vs 9.88s on master (0% slower)

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented Oct 1, 2017

Codecov Report

Merging #1872 into master will increase coverage by 0.02%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1872      +/-   ##
==========================================
+ Coverage   88.61%   88.64%   +0.02%     
==========================================
  Files         239      240       +1     
  Lines       11699    11763      +64     
==========================================
+ Hits        10367    10427      +60     
- Misses       1332     1336       +4
Impacted Files Coverage Δ
...les/UnneededParenthesesInClosureArgumentRule.swift 95.74% <ø> (ø) ⬆️
Tests/SwiftLintFrameworkTests/RulesTests.swift 100% <100%> (ø) ⬆️
...intFramework/Rules/UnneededBreakInSwitchRule.swift 93.54% <93.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41f8b19...192411f. Read the comment docs.

@marcelofabri marcelofabri merged commit bb26351 into realm:master Oct 2, 2017
@marcelofabri marcelofabri deleted the unneeded_break_in_switch branch October 2, 2017 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants