New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule request: unneeded break in switch #1870

Closed
marcelofabri opened this Issue Oct 1, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@marcelofabri
Collaborator

marcelofabri commented Oct 1, 2017

New Issue Checklist

Rule Request

When using switch statements, avoid adding explicit break.

  1. Why should this rule be added? Share links to existing discussion about what the community thinks about this.

From Erica Sadun's Swift Style book:

Avoid adding unneeded break statements. Swift naturally ends evaluation at the end of a case. Don’t pad your code to look like other languages that don’t offer this safety feature.

  1. Provide several examples of what would and wouldn't trigger violations.
// should trigger
switch foo {
case .bar:
  something()
  break
default:
  break
}

// shouldn't trigger
switch foo {
case .bar:
  something()
case .bar2:
  somethingElse()
}

switch foo {
case .bar:
  break
case .bar2:
  somethingElse()
}

switch foo {
case .bar:
  for i in [0, 1, 2] {
    break
  }
case .bar2:
  somethingElse()
}
  1. Should the rule be configurable, if so what parameters should be configurable?

Just the severity.

  1. Should the rule be opt-in or enabled by default? Why?
    See README.md for guidelines on when to mark a rule as opt-in.

Enabled by default.

marcelofabri added a commit to marcelofabri/SwiftLint that referenced this issue Oct 1, 2017

marcelofabri added a commit to marcelofabri/SwiftLint that referenced this issue Oct 2, 2017

sirlantis added a commit to sirlantis/SwiftLint that referenced this issue Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment