Bump Sync to 3.10.1 #1772
Bump Sync to 3.10.1 #1772
Conversation
nirinchev
force-pushed
the
ni/new-sync
branch
from
a107aa8
to
a4705aa
Compare
|
If this solves as well #1813, then please close the issue. |
| @@ -192,7 +175,12 @@ public static unsafe void ConfigureFileSystem(UserPersistenceMode? userPersisten | |||
| modePtr = &mode; | |||
| } | |||
|
|
|||
| NativeMethods.configure_file_system(basePath, (IntPtr)basePath.Length, modePtr, encryptionKey, resetMetadataOnError, out var ex); | |||
| // TODO: provide proper user agent. | |||
There was a problem hiding this comment.
Better to point to an actual issue here
There was a problem hiding this comment.
I have a follow up PR that fixes it.
CHANGELOG.md
Outdated
| vNext (TBD) | ||
| ------------------ | ||
|
|
||
| The sync protocol version has been bumped to version 25. The server is backwards-compatible with clients using protocol version 24 or below, but clients at version 25 are not backwards-compatible with a server at protocol version 24. The server must be upgraded before any clients are upgraded. |
There was a problem hiding this comment.
I wouldn't refer to the sync protocol version - it's not a known number. What users know is the ROS version.
You could take inspiration for the text for e.g. realm-js:
You will need to upgrade your Realm Object Server to at least version 3.11.0 or use Realm Cloud. If you try to connect to a ROS v3.10.x or previous, you will see an error like Wrong protocol version in Sync HTTP request, client protocol version = 25, server protocol version = 24.
Co-Authored-By: nirinchev <irinchev@me.com>
Co-Authored-By: nirinchev <irinchev@me.com>
Co-Authored-By: nirinchev <irinchev@me.com>
| ### Enhancements | ||
| * Download progress is now reported to the server, even when there are no local changes. This allows the server to do history compaction much more aggressively, especially when there are many clients that rarely or never make local changes. ([#1772](https://github.com/realm/realm-dotnet/pull/1772)) | ||
|
|
||
| ### Fixed |
There was a problem hiding this comment.
I'm sure the sync upgrade fixes many issues - it might be a bit of work to enumerate those. But at least it should be mentioned that very critical bugs have been fixed.
There was a problem hiding this comment.
I believe it's all server-side fixes, do we expect any of these to affect clients?
There was a problem hiding this comment.
Yeah there was definitely some fixes that meant that old clients could introduce bugs (was that no-merge invariant)?
CHANGELOG.md
Outdated
| * The deprecated method `realm.SubscribeToObjectsAsync` has been removed in this version. ([#1772](https://github.com/realm/realm-dotnet/pull/1772)) | ||
|
|
||
| ### Internal | ||
| * None. |
There was a problem hiding this comment.
Mention the upgrade of sync from X to Y
|
Hey - looks like you forgot to add a T:* label - could you please add one? |
* master: (89 commits) Prepare for 4.0.1 (#1876) Fix iOS device builds (#1875) Prepare for 4.0.0 (#1868) Refactor packaging (#1849) Update CHANGELOG.md (#1828) Add session.stop/start methods (#1839) Prepare for 3.4.0 (#1826) Ensure GetInstanceAsync works with QBS config (#1827) Add ability to define custom log function (#1824) Add support for user agents (#1819) Bump Sync to 3.10.1 (#1772) Update ISSUE_TEMPLATE.md Release 3.3.0 (#1808) Expose SyncConfiguration.OnProgress (#1807) Throw an error when trying to call async subscription methods on background threads (#1783) Update CHANGELOG.md (#1777) Prepare for 3.2.1 (#1775) Fix subscription state size (#1774) Release 3.2.0 (#1769) Add ShouldCompactOnLaunch to the PCL RealmConfig (#1768) ... # Conflicts: # Platform.PCL/Realm.PCL/Extensions/CollectionNotificationsExtensionsPCL.cs # Tests/Tests.Shared/CollectionTests.cs
Description
Related to https://github.com/realm/raas/issues/1173