-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create empty/dummy documentation for C#. #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned kneth
Sep 30, 2013
DennisFantoni
added a commit
that referenced
this pull request
Sep 30, 2013
Create empty/dummy documentation for C#.
Don't include anything from /html |
alazier
added a commit
that referenced
this pull request
Oct 27, 2015
Merge objectstore changes from obj-c
AndyDentFree
added a commit
that referenced
this pull request
Nov 24, 2015
f780342 Merge pull request #7 from realm/tg-results a8f1b23 Eliminate a query copy in Results::filter() 5683fa1 Use make_optional() 1698da2 Fix typo in comment d7fe9f9 Expose the object class name from Results d1175fe Switch to throwing exceptions with all of the info needed to build error messages 9dc5165 Fix compilation with GCC 4.9 ab7f3dc Port most of RLMResults's functionality to realm::Results 73b605d Add results.{hpp,cpp} from realm-js a492966 Move Realm::Config's default constructor out-of-line 028ed2a Merge pull request #9 from realm/al-accessors e3c9ec8 fixes to list.cpp/hpp based on object store pr feedback - use lowercase strings for property names 9d373e6 Update data properties to return ArrayBuffers 85286b8 block refresh until the last context has finished execution e473299 integrate latest object store changes 638ee4d integrate latest object store changes 7701ba1 Merge pull request #16 from realm/tg-close 883ef12 Add Realm::close() and call it in RealmCache::clear() e9ca54e Merge pull request #12 from realm/tg-core-0.94.4 0823a62 Merge pull request #13 from realm/tg-is-empty 62f59d9 Merge pull request #15 from realm/tg-file-error-path b93e5ce Include the path of the file which actually failed to open in exceptions e1e9cd8 Add ObjectStore::is_empty() 52e7e61 Update for core 0.94.4 271432b Merge pull request #11 from realm/kd-rename-delegate-to-bindingcontext db36ca5 Remove Realm suffix 70e1967 Rename realm delegate in transact_log_handler as well 4973827 Rename RealmDelegate to RealmBindingContext 2e2beab change the license before starting the beta faa1297 support null for basic propety types dca7e7d enable nullable propeties without a macro ccdfaa8 use typed exceptions ff9b73e Non-existent object getters shouldn't throw exceptions ed193d8 make list members private c9ef337 make object members private 31819a5 Merge commit '347145b4f1c40409c68af0ad61be15ee5f9d04f2' into al-os 1fa7c01 clean up per realm resources/threads dace775 store schema and prototypes on the realm object 8a2e24d move property getters to object store code 06260bc move List class to its own file 286c652 Merge pull request #55 from realm/al-migrations b27b794 pr fixes ad677b7 allow running all tests at the same path by invalidating all cached realm paths between test runs c8b6efb Out of bounds getters for Results return undefined b70e543 Setting properties outside transaction should throw d88b089 update to latest object store code 0c18978 Send changes_available() even if autorefresh is enabled cb7360c use latest object store changes 981e700 Fix error in cleanup after an error during a migration 1fcc5a1 Simplify column shifting for removed properties a little df6d6e8 Add a Schema class, move lookup by name and internal-consistency checks there d72d79b Make Realm::compact() more robust a5f21e5 Reduce the scope of a variable 9075917 Fix a comment 924482a Fix checks for what types of columns can be optional d3a218d USe more const refs to avoid copies cc6364f Make a bunch of things const fb18624 Remove an unused function 515ce62 Share ExternalCommitHelpers between Realm instances for a single path 873d24f Allow more nullable property types when supported 663492e Honor is_nullable when creating columns ce39ef9 Refactor schema initialization a bit 4dd72d4 Move the interprocess notification functionality to the object store 5ffeedb Shuffle stuff around and clean some things up 429a652 Improve array KVO performance a bit 2f86954 Skip PK uniqueness checking when first creating a Realm file 9129add Improve performance of realm_requires_update() and make more things const 9403c6f Port some of the KVO support functionality to the object store 524edf0 Add the ability to bypass the Realm cache entirely aae979c Rework change notifications ce8060b Add Realm::get_schema_version() 6df3719 Change realm::Schema to a vector rather than a map bf3d9bd Remove property.hpp include from object_schema.hpp 6b43c4c Convert RLMRealmConfiguration to a wrapper around Realm::Config 169bdb6 Use NSDMIs for realm::Property c6d82ad Don't cache dynamic realms in the ObjectStore cache either 06ce250 Eliminate some copies 6a491ea Use NSDMIs for Realm 9c224fb Reduce s_init_mutex's scope d6566ff Use NSDMIs for Realm::Config and make it moveable 5c1e20a Store a copy of the encryption key 591ec90 support defaults a099682 more extensive upsert tests beb7c19 support sorting by a single property e2836f7 fix for partial update of string properties 9ca8e46 primary keys and upsert 942af6a todo example 6d1c000 test existing array functionality 6b79194 proper copyright 8759bbb Merge commit '070042894536c87cc3d3c7fdcb62b75e3620dc34' 8ad79f1 missing files and project fixes REVERT: c25c6c1 Merge pull request #214 from realm/yg-datetime REVERT: 7853add Refactor the DateTimeOffset to Unix time conversion REVERT: 3057f17 Use the proper DateTime storage type from core REVERT: 51d57e7 Add support for DateTimeOffset properties REVERT: ff1ef77 Merge pull request #206 from realm/kd-install-doc-update REVERT: c29351d More updates REVERT: 250941c Documentation updates REVERT: 7fc2d81 Merge branch 'master' of github.com:realm/realm-dotnet REVERT: db99cbb Merge pull request #205 from realm/kd-polish-for-mvp REVERT: df9aac7 Add comment to CheckSystemVersion call REVERT: 916574a Remove redundant TODO comments in InteropConfig REVERT: b3bb7ea Optional databasePath parameter REVERT: 1b495ad Fix Ignore -> Ignored in Playground Person class REVERT: f8bc000 Fix namespaces in ios interopconfig REVERT: 5ad0567 Add default database path when using null REVERT: 8b9bde2 Style cleanup in MarshalHelpers.cs REVERT: 36b584f Ignored attribute fixed in weaver REVERT: 50b39fc Ignored attribute fixed in weaver REVERT: 4396c11 Remove some noise from InteropConfig files REVERT: ea9367d License file updated REVERT: 3d9b6aa Merge pull request #201 from realm/kd-rename-attributes-#194 REVERT: c47b195 Ignore -> Ignored REVERT: d3c8f90 PrimaryKey -> Identifier REVERT: 8453bcf Merge pull request #200 from realm/ad-fix-exception-throwing-#198 REVERT: f3c6dd9 error_handling.cpp - realm::convert_exception cleaned up to directly use e.what() instead of lambda which was originally composing message with file and line but had been cut back to just call what() but was on base class so not hitting override. REVERT: 5e28d12 Merge pull request #193 from realm/kd-introduce-library-nuget REVERT: 4185f44 Documentation added REVERT: 76dd821 Merge pull request #197 from realm/ad-fix-differential-libwrappers REVERT: 25328f8 Fix problem with librwrappers not being found for different configurations by using conditional configurations rather than putting symbol in path REVERT: 675feef Merge pull request #196 from realm/ad-build-ios-wrappers-debug REVERT: 66cdb97 Cleaned up Makefile a bit more adding "ios" and "osx" targets REVERT: 4ee4156 Making wrappers build for IOS with debug to aid debugging from XCode REVERT: c48ea3d Fixes in weaver nuspec REVERT: a033717 Removed redundant FodyWeavers.xml from Nuget.Library REVERT: 29cb0b4 Update solution and weaver project. REVERT: a45dfe6 Update weaver test project REVERT: 9139b24 Update solution and test project with .fody suffix REVERT: ca0a2bb Rename RealmNetWeaver to RealmNetWeaver.Fody REVERT: 29db57f Remove .ncrunchproject files from index REVERT: 54843ee Add a few exceptions to .gitignore REVERT: b5e835a Introduce library nuget REVERT: f2d666b Add readme to weaver nuget REVERT: 5366e7d Rename project file REVERT: 4a0d86c Merge pull request #192 from realm/kd-nuget-move-folder REVERT: 20086cd Move NuGet files into NuGet/NuGet.Weaver folder REVERT: f0f72ca Merge pull request #190 from realm/kd-add-copyright REVERT: 39f0642 Add proprietary copyright header to source files REVERT: ecb0655 Merge pull request #189 from realm/ad-linq-search-float-double-#68 REVERT: dcfc11c Fixed spaces as per PR REVERT: ff71eca #68 Adding float and double search support REVERT: 3c59380 Merge pull request #188 from realm/ad-float-double-storage-#67 REVERT: 1dddad9 DLLImport additions for float/double set and get REVERT: e503d96 Merge pull request #187 from realm/ad-float-double-storage-#67 REVERT: c939978 #67 Adding float and double support REVERT: 3cb213f Merge pull request #186 from realm/ad-float-double-storage-#67 REVERT: f23c5be -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Fixed integration tests to actually test if stored and fix IOS test REVERT: d2dfd22 Merge pull request #185 from realm/kd-minor-fixes REVERT: 6120e64 Typo fix in WeaverTests REVERT: bd332a6 Merge pull request #184 from realm/kd-remove-tightdb-folder-2 REVERT: f2c0c2f Update README REVERT: 22e1aa9 Fix paths in wrappers REVERT: fbf0fd7 Move files from realm/ to / REVERT: a88ae14 Remove tightdb folder REVERT: 62b65a9 Update/merge .gitignore and .gitattributes REVERT: 73203c4 Merge pull request #180 from realm/kd-fix-ios-build-errors REVERT: a7e7765 Include paths fixed REVERT: 69e07d0 Reorganizing REVERT: 7895450 Merge pull request #178 from realm/kd-fix-wrapper-errorhandling REVERT: 2197bad Remove CheckTablesTest from win32 playground REVERT: 4905029 Add RealmOutsideTransactionException REVERT: 0270d2b Test GetInstance REVERT: 6ba6887 Call SetupExceptionThrower REVERT: 2407d8a Convert some tabs to spaces REVERT: f444e7c A bit of test cleanup REVERT: be31f2e Validate transaction when creating/mutating objects REVERT: 8d1575f Remove deleted files from project REVERT: 8ab6478 Marshalling fixes in NativeSharedRealm REVERT: 3655641 Remove superfluous process_error REVERT: 073492b Update windows "implementation" og external_commit_helper REVERT: 427c733 add <mutex> include to shared_realm REVERT: 2608e7d Wrap remaining functions in handle_errors REVERT: 67eff9d Fix two small compiler errors REVERT: 3cccbb9 Remove files that have been merged into error_handling REVERT: 071712f Handle object store exceptions with convert_exception REVERT: 2e5c96f Add some integration tests REVERT: d171b4e Merge pull request #177 from realm/kd-rename-realm-export-decls REVERT: e484c04 Rename realm_export_decls.hpp to realm_exportd_decls.h REVERT: 550195c Merge pull request #176 from realm/kd-update-object-store REVERT: fca19df Merge commit '347145b4f1c40409c68af0ad61be15ee5f9d04f2' into kd-update-object-store REVERT: acfb406 Gitattributes added to tightdb REVERT: ec7ccf9 Merge pull request #172 from realm/kd-reintroduce-realmnetweaver-tests REVERT: cb5a787 Reintroduce RealmNetWeaver tests REVERT: 700d9c2 Add ncrunchproject to gitignore REVERT: f41fe9f Update Fody REVERT: f3b2efe Merge pull request #171 from realm/kd-wrapper-cleanup REVERT: 5520f7a Update Playground to commit transactions explicitly REVERT: e57af39 Comment out HomePageTest for now as it doesn't compile. Remove BeginRead() as they are no longer required REVERT: ef12123 Cleanup in makefile REVERT: fcf83c3 Make transaction roll back per default until we figure out what to do REVERT: 1402cf7 Update xcodeproject with source files REVERT: 5b64ff3 Update makefile to reference all cpp files instead of wrappers.cpp REVERT: 40140ce reference shared_realm.hpp relatively in external_commit_helper.cpp REVERT: 51f2936 Outcomment exceptions that did not exist in core 0.92.1 REVERT: e018643 Random cleanup REVERT: b0f99ab Introduce HANDLE_ERRORS_OPEN/CLOSE macros REVERT: 39f3229 Merge pull request #169 from realm/kd-split-ffi-into-separate-files-#163 REVERT: 85470a1 NativeRow.row_destroy -> NativeRow.destroy REVERT: bf72064 *_delete renamed to *_destroy REVERT: 0f9f8cf A single tab converted to spaces in NativeQuery.cs REVERT: c3e6fcb Reorganizing code. REVERT: fbed9fd Merge pull request #168 from realm/kd-schema-configuration-#162 REVERT: 2d8dfa2 Fix compiler error in program.cs REVERT: ca99e09 Merge pull request #167 from realm/kd-schema-configuration-#162 REVERT: 1eb95f3 Removed ObjectSchemaHandle as ownership takes place in C++ REVERT: d81f71e Add std::move to add_object_schema REVERT: bafa355 Removed erroneous reliability contract from SharedRealmHandle REVERT: 15190b3 Reliability contract added to ObjectSchemaHandle as well REVERT: cf80749 Reliability contracts added to a few handles REVERT: 0db53aa (random cleanup) REVERT: d1d7245 Nullable support added, along with primary key and indexing. REVERT: 25a029a Removed faulty schema_destroy REVERT: eb62a80 Add schema initialization REVERT: 6f5b9be Add schema initializer REVERT: 843f88f Merge pull request #165 from realm/kd-post-remove-coreprovider-cleanup REVERT: 31e4eb8 Outcomment some performance tests that currently don't build REVERT: f82d112 Move InteropConfig into RealmNet namespace REVERT: cfe5b92 RealmNet.Win32: Allow unsafe code for all configurations REVERT: 82a8178 Remove some redundant Native-code REVERT: 39dc062 Remove redundant handle interfaces REVERT: d4ff3ee Merge pull request #156 from realm/kd-introduce-objectstore-#144 REVERT: d6acad5 Reintroduce Realm.Remove() REVERT: cdec48f CoreProvider classes removed REVERT: 72269bd Make queries work: move from CoreProvider into Realm and related classes REVERT: 4bc0017 get_table uses correct utf-16 string REVERT: 7297a97 utf16accessor isolated REVERT: 9c3d42c Fix signature for get_table REVERT: 9bc2c3a Add transactions to the Realm class REVERT: 2b0a4c1 Outcomment references to GetListValue in weaver for now REVERT: 786d1a3 Win32-playground added to RealmNet solution REVERT: a0ae243 Win32 playground: add Person class and simple test. REVERT: e0fdb20 Added SetValue to RealmObject. REVERT: cb03062 Transaction class added (empty shell that "contains" a promote-to-write call) REVERT: c24653a shared_realm_get_table introduced (not working yet) REVERT: 08be30a Transaction class "reintroduced" REVERT: 36ac7e3 Various refactorings. Doesn't build at this moment. REVERT: ade26f8 Group, Transaction and TableViewHandle removed REVERT: 1ef1679 Give Playgound.Win32 access to internals REVERT: ae52c2e Organize files into folders REVERT: a6199d5 Introduced Playground.Win32 REVERT: bb25d76 Split into Native* files REVERT: a04fd20 Added object-store to wrappers vs-project REVERT: c439fdf Renamed realm_export_decl to realm_export_decls REVERT: 0a3cc57 merge REVERT: d0d7e57 First NativeRealm test.. REVERT: f50554d Add NativeRealm.cs REVERT: bcff145 Merge pull request #160 from realm/ad-splitting-wrappers-#104 REVERT: 5b59226 REALM_API renamed to REALM_EXPORT REVERT: 71d8407 add _HPP to include guard REVERT: 7d6c20d #155 Intercepting exceptions in wrappers - responses to PR WindowsDLLWrapperDecls.h - renamed realm_export_decls.h - REALM_CORE_WRAPPER_API renamed REALM_EXPORT REVERT: 4187704 Fix namespace issue in Playground.XamarinIOS REVERT: 6306a27 Update xcode project to include object store REVERT: f9b05b1 Deleted files copied from Java to use as base with same name and functionality - have factored out into more clearly-named files and our exception handling is now a bit more different than anticipated,so there's more confusion than benefit in propagating these names. REVERT: de42bfd Merge branch 'master' into ad-splitting-wrappers-#104 REVERT: dcd8933 More minor doc updates REVERT: ad4fc24 Updated doc slightly REVERT: d9acd93 Responding to PR - renaming files to standard_naming Include documentation changes to get Exception documentation generating with Doxygen REVERT: c6ba236 Merge pull request #158 from realm/ad-intercept-exceptions-in-wrappers-#155 REVERT: 9a89f47 Renamed header files to ".hpp" standard REVERT: 5e1f69b Replaced #pragma with include guards REVERT: 69e6ec0 #155 Intercepting exceptions in wrappers REVERT: e464fae Merge pull request #157 from realm/ad-exception-handling-in-wrappers-#155 REVERT: 238cfe4 Minor fix for Windows - added the DLL linkage specifier REALM_CORE_WRAPPER_API REVERT: 4302156 #155 EXCEPTION HANDLING IN WRAPPERS - CSHARP SIDE AND COMMS WITHOUT THROWING REVERT: 8569c99 realm.cpp turned into ffi.hpp + ffi.cpp with configurable error handling REVERT: 51274bf Mostly doc changes on how builds and splitting works, along with including NativeRow into projects REVERT: 78dd2b6 Fake Windows external_commit_helper "implemented" REVERT: 0b2c82f Add object store to wrappers project REVERT: 59e2f55 Make schema initialization rely on a vector of ObjectSchema's REVERT: 0cf0d09 realm.cpp from rust-binding added REVERT: d85995b Subtree merged in realm-object-store REVERT: ae1fea9 Merge pull request #154 from realm/kd-fix-handle-refcount-bug REVERT: 802119e A few comments and constrained execution region annotation REVERT: 54de73b Added nunit to packages.config REVERT: e43f0b1 More detailed performance tests REVERT: 9675c63 Add REALM_32 to release mode for RealmNet.Win32 REVERT: a5e5cea Downgrade to Nunit 2.6 REVERT: 570900b Improved comment for Person.IsOnline (example class) REVERT: 68878fe Add NativeRow to RealmNet.Shared REVERT: 5aef9cc Only catch RealmHandle.ReleaseHandle exceptions in release mode REVERT: 169ca81 Use .handle (IntPtr) instead of this for various access to native pointers. Fixes a reference count bug. REVERT: 7117f7b Outcomment NativeGroup.ToString until it's implemented in wrappers REVERT: e3e0255 #104 copying files util.hpp/cpp prior cleanup REVERT: bc352fc Merge pull request #153 from realm/ad-splitting-wrappers-#104 REVERT: d37a756 #104 splitting wrappers.cpp REVERT: 78a6ca1 Merge pull request #151 from realm/ad-splitting-wrappers-#104 REVERT: 85813f0 minor doc fix from PR REVERT: d881fb7 Documents updated to match current state of solutions and projects and project cleanups for RealmWin.sln so uses new shared projects REVERT: 009e6d4 Merge pull request #150 from realm/ad-make-android-test-runner-#148 REVERT: a075ad4 Diary changes for previous PR REVERT: bbe91b7 Merge pull request #149 from realm/ad-make-android-test-runner-#148 REVERT: 40cf6a8 #148 Add Android Integration Tests and Refactor Testing REVERT: 7452b18 #148 Add Android Integration Tests Built test runner compiling and deployed on Moto-G REVERT: 2b1337e Merge pull request #147 from realm/ad-fix-project-configs-#139 REVERT: abb8398 Unsaved document changes REVERT: 8923972 Merge pull request #146 from realm/ad-fix-project-configs-#139 REVERT: 7789498 Playground.XamarinAndroid/MainActivity.cs IntegrationTests.XamarinIOS/IOSIntegrationTests.cs IntegrationTests.XamarinIOS/IOSPerformanceTests.cs - removed using RealmNet.Interop REVERT: ebfa565 #139 Fix project configs REVERT: 8eecc1b RealmNet.win32.csproj - added reference to wrappers.vcxproj REVERT: 3ebed14 wrappers.vcxproj - Debug|Win32 and Debug|x64 platform toolset changed from v140_xp to v140 to match core REVERT: 0162305 #139 Fix project configs - Win32 and IOS added back REVERT: 012d846 #139 Fix project configs and duplicate project GUIDs Added blank RealmNet.sln REVERT: 0262b36 #139 Fix project configs so only build in the correct configs REVERT: 423e4ae Merge pull request #138 from realm/kd-fix-expressionvisitor-#128 REVERT: fe9d979 Introduce ExpressionVisitor REVERT: 647349b Merge pull request #134 from realm/kd-fix-property-remapping-#125 REVERT: 880b6a3 Merge pull request #135 from realm/kd-namespace-cleanup-#130 REVERT: 37a3ea2 Merge pull request #132 from realm/ad-fix-renamed-xamarin-ios-test REVERT: 67ba89e Unify namespaces, clean up using statements in RealmNet.Shared REVERT: c466b8a Abstract integration test classes moved into IntegrationTests.Shared REVERT: 927d9d7 PCL version of IntegrationTests removed REVERT: 5ec3ffd Change Person.cs to use remapping again REVERT: da2eb61 Fix remapping (and inherited!) properties bug REVERT: ab73218 AssemblyInfo files updated from Interop to RealmNet. REVERT: 4e5a983 Fix renaming of IntegrationTests.IOS to IntegrationTests.XamarinIOS REVERT: 5c502ae Merging IntegrationTests.IOS with the new shared project arch REVERT: 99c0141 Merge branch 'ad-IOS-integration-tests-#118' REVERT: a432082 Merge pull request #124 from realm/kd-convert-to-net35-experiment REVERT: b4535b6 #118 Adding IntegrationTests.IOS Removed the IntegrationTestsAsLib project Copied some Setup down to IOSPerformanceTests so they work without having to change the parent class as much. Fairly interim checkin with cleanup needed to pull into new shared architecture. REVERT: 94b4315 RealmNet.* assemblies renamed to RealmNet REVERT: 95de47b Fixes for XS: Xamarin.MAC and minor things REVERT: 311fcb6 Solution uses new projects REVERT: 5cee80a Unimplemented methods texts moved REVERT: 48f7203 Interop.XamarinMAC renamed to RealmNet.XamarinMAC REVERT: c682089 Interop.XamarinIOS renamed to RealmNet.XamarinIOS REVERT: 9f2e0bc Interop.XamarinAndroid renamed to RealmNet.XamarinAndroid REVERT: 0607999 Interop.Win32 renamed to RealmNet.Win32 REVERT: d346a80 Shared files gathered in RealmNet.Shared REVERT: c47bbde Interop.ios and android use interop.shared REVERT: 7969ee3 Interop.Shared introduced as a shared project. REVERT: d74ad7b #118 Corrected "InternalsVisibleTo" name REVERT: 8f00a0f OOPS missing file - it IS here REVERT: 8356c4f #118 Adding IntegrationTests.IOS REVERT: 2593378 #118 Adding IntegrationTests.IOS REVERT: 6557b09 #118 Adding IntegrationTests.IOS REVERT: d985b2c Merge pull request #120 from realm/ad-quickFixReorgUnsafe REVERT: 7e504cd Minor tweak to make include library specifications simpler and not platform-specific, using macros to get 86 or 64 REVERT: 11a7875 Merge pull request #119 from realm/kd-performance-test-experiment-2-#105 REVERT: 92c66d1 Name clarifications in weaver code REVERT: 964707c Fix Integration Tests copying Wrappers DLL REVERT: e2facd2 Fix property mapping in weaver REVERT: 7b65b85 Ignore failing remove-test until implicit transactions are implemented REVERT: eeb99f8 Removed redundant files from win32/shared REVERT: 722e0ad Commented-out code removed from TableHandle, minor simplifications REVERT: bcd876b IntegrationTests readme added REVERT: 582f9aa Merge branch 'master' of https://github.com/realm/realm-dotnet into ad-quickFixReorgUnsafe REVERT: 1c4c0a8 Revert "Minor README update removing outdated mis-leading build info" REVERT: 4bf8ccc Minor README update removing outdated mis-leading build info REVERT: b9e4e7d Merge pull request #117 from realm/kd-default-path-in-getinstance REVERT: af05bba Redundant compiler constants removed REVERT: 95a5253 merge REVERT: 0109944 Inconsistent brace-placement fixed REVERT: 41e5cfe Merge branch 'master' into kd-default-path-in-getinstance REVERT: ef592f3 merge REVERT: 95dac41 Merge pull request #114 from realm/kd-simple-benchmarks-#105 REVERT: e57566f db file renamed to db.realm, IntegrationTest uses default path REVERT: 0ea5cf4 Performance tests better aligned (raw vs. binding-based) REVERT: 3b6ddef Basic performance test running REVERT: 49e3131 Changed wrongly named RowIndex to RowHandle REVERT: cd6ec84 RealmNetWeaver tests reintroduced, not testing anything at the moment, REVERT: 1864e09 Raw performance test implementation begun REVERT: 088e1de Test files renames REVERT: 1d7fdb9 Removed useless test-disk-usage test REVERT: af8d3c6 IntegrationTest converted to PCL. IntegrationTests.Win32 added. REVERT: 19de7b7 Merge pull request #113 from realm/ad-reorg-unsafe-and-wrappers-#82 REVERT: 81a67bb Renames after refactoring, to simplify: NativeGroup.group_ =?> NativeGroup. NativeQuery.query_ => NativeQuery. NativeTable.table_ => NativeTable. NativeGroup.shared_group_ => NativeSharedGroup. REVERT: 25c419b #82 splitting unsafe native methods Split NativeGroup into NativeGroup and NativeSharedGroup as per PR REVERT: 740796f #82 splitting unsafe native methods REVERT: 0dddbfa Correct path on IOS 8 REVERT: bde102f Merge branch 'master' into kd-default-path-in-getinstance REVERT: 17430d1 Merge pull request #112 from realm/ad-FixMissingGetListValue REVERT: 00ccf85 Add missing (unimplemented) Get/SetListValue methods REVERT: f5f382c Merge branch 'master' into kd-default-path-in-getinstance REVERT: 6208e77 #82 Reorg Wrappers Push new document describing layout with Google Sheet link REVERT: c9cb8de Merge pull request #108 from realm/ad-link-and-linklist-#91 REVERT: add1dda #91 Link and LinkedList Change to using a var as requested in code review REVERT: c1ceeee Merged with #102 REVERT: 72c5799 Merge pull request #102 from realm/kd-add-removetablerow REVERT: ff8d6f8 #91 Link and LinkedList - cleanup REVERT: ce2a7cb Merge branch 'kd-add-removetablerow' of github.com:realm/realm-dotnet into kd-add-removetablerow REVERT: 416caae FakeRowHandle changed to use RowIndex REVERT: 70a074f Left-over static test experiment removed REVERT: 8bb5664 RowHandle links added to Xamarin interop projects REVERT: 7a57814 RowHandle.RowIndex added to IRowHandle REVERT: c848307 table, row and query delete/unbind added to wrappers.cpp REVERT: e428727 Added table, query and row delete/unbind in wrappers. REVERT: 0a50b90 Only copy wrappers.dll to output dir when changed REVERT: 7d72bff Diagram originals for the architecture being debated tonight REVERT: 2dcb32f Added RemoveTest REVERT: c8a8e9d Added equals to RealmObject and RowHandle REVERT: b6449b6 Move ISharedGroupHandle into separate file REVERT: 9d12c72 Use Row* and RowHandle instead of row index in various places REVERT: 96c51b2 [WIP] #91 Link and LinkedList samples REVERT: aae1fe6 Removed commented out line REVERT: b413a22 Removed wrongly pushed CreateTables code (doesn't belong in this branch) REVERT: c9b3541 CreateSharedGroup works with filename=null REVERT: 2b6a2c1 Merge branch 'master' into kd-add-removetablerow REVERT: 8426bfa Merge pull request #92 from realm/kd-query-without-conditions-bug-#89 REVERT: 13806bb Merge branch 'master' of https://github.com/realm/realm-dotnet REVERT: 05d6855 Update and more readme to the top so it's visible at first look at the repo REVERT: ceb5d8a Remove exercised in ViewController (the ios "integration test") REVERT: 2808063 Remove row added to wrappers and Realm REVERT: 9f7f2d0 Merge pull request #86 from realm/ad-new-add-syntax-#63 REVERT: e4a62e5 RealmObject InRealm and IsStandalone made properties REVERT: 5cc4c69 ignore .bz2 files we download in the wrapper builds REVERT: 6f6ab13 Minor changes in response to the PR comments, fixing case and breaking single-line ifs REVERT: 21cd34d Check for overflow in wrappers query_find REVERT: 30410df IntegrationTests include condition-less query REVERT: baf5098 Link wrappers to core built locally REVERT: 01d178a Added gitattributes REVERT: cba9a89 #63 new Add Syntax - demo file REVERT: be088be #63 new Add Syntax - demo file REVERT: 80f9eb6 #63 new Add Syntax - demo file REVERT: b661849 #63 Standalone Objects - Minor fixes to transactions REVERT: 2007fc0 Minor doc addition REVERT: 439e954 UnsafeNativeMethods.shared.cs CoreProvider.shared.cs - fix wrapper calls and rename for consistency query_begin_group => query_group_begin query_end_group => query_group_end REVERT: 5476e0f #63 Standalone Objects and better Add syntax REVERT: 919d9d8 Updated blank read.md REVERT: ef28c68 Merge pull request #80 from realm/kd-ios-crash-bug-fix-#57 REVERT: 4e72782 Removed upgradelog REVERT: be09e25 Resolved conflict in CoreProvider REVERT: 634351b Merge branch 'kd-ios-crash-bug-fix-#57' of github.com:realm/realm-dotnet into kd-ios-crash-bug-fix-#57 REVERT: f6886b5 table_unbind and query_delete TEMPORARILY outcommented REVERT: d37c0c8 Merge pull request #81 from realm/ad-LINQ-combinatorial-#72 REVERT: 5bab848 #72 LINQ Combinatorial Expressions response to code review REVERT: 9b97997 Create the proper library path on ios8. REVERT: b0548dd Out-commented a few unimplemented UnsafeNativeMethods, added new_shared_group_file for constructing a shared group with explicit parameters. REVERT: ffabd10 Removed core from git (now downloaded by make) REVERT: 74a2641 #72 LINQ Combinatorial Expressions plus int support REVERT: ea2372f #72 LINQ Combinatorial Expressions plus int support REVERT: 6904bf9 Typo in a comment :-) REVERT: ced652e Playground.XamarinIOS runs integration test visibly on device (instead of console) REVERT: da7f8eb Upgrade Fody in Playground.XamarinIOS REVERT: d686acc Allow native debugging of Playground.xamarinIOS REVERT: 84e0acf Added [preserve] attribute to SharedGroupHandle constructor REVERT: 22e8f74 Added stdlib linker flag for ios interop REVERT: b8af099 #72 LINQ Combinatorial Expressions (WORKING except for And through to core) REVERT: 21b2dca Merge pull request #71 from realm/ad-refactor-leaning-up-native-methods-#70 REVERT: 3fa4db4 #79 propagating refactoring pattern from #66 REVERT: 0c5d34f #79 propagating refactoring pattern from #66 REVERT: 50010fa Merge pull request #69 from realm/ad-linq-binary-ops-to-core#66 REVERT: 6e52af0 #66 LINQ through to the core - refactoring platforms REVERT: c2f2459 #66 LINQ through to the core - string, bool equals and int searches REVERT: f52eff7 Merge pull request #64 from realm/ad-linqOnRefactored-#50 REVERT: aabb74e #50 LINQ on one table - simple tests of results with LINQ to Objects REVERT: e11a5ba #50 LINQ on one table - adding bool and float REVERT: 99898ca #50 LINQ on one table - single query operators mocked Response to PR comments REVERT: f31e26a #50 LINQ on one table - single query operators mocked REVERT: 665daf0 Builds and runs tests in pure AnyCPU .Net mode, now adding in extra Mock LINQ tests REVERT: fd9a4b1 Merge branch 'master' of https://github.com/realm/realm-dotnet into ad-linqOnRefactored-#50 REVERT: b71dabe Merge pull request #62 from realm/ad-crashingWin32-#59 REVERT: d6426b8 #50 LINQ on one table - weaving in the sample REVERT: 1c73ef0 -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- #50 Mocking merge on refactored REVERT: de42151 #59 Fixing Configs REVERT: 979453d Minor changes to Interop.win32 adding x86 and x64 configs so can build x86 without needing or copying x64 wrapper DLL REVERT: 648ddcd Weaver fix - remove lines that generate redundant copy from stack/load back to stack that were causing the generation of invalid IL in x86 builds, for our getters. REVERT: 0e784f5 Merge pull request #56 from realm/kd-sharedgroup-basics-#23 REVERT: f01faa2 AbortTransaction made private in SharedGroupHandle REVERT: 3afd968 Removed some unreferenced legacy files REVERT: 83ceacf IOS Playground uses transactions. Doesn't work yet though REVERT: 095db70 Shared links fixed in XamarinIOS and XamarinMAC projects REVERT: b4f4f76 Broken QueryTest commented out. Not sure how to resolve. REVERT: 00e66fc Queries reimplemented, still only just working. REVERT: 6652ae6 SimpleTest in IntegrationTests uses transactions REVERT: 2fedd34 Group handle added to various CoreProvider methods REVERT: e6f125f Added group_has_table and table_get_column_index to UnsafeNativeMethods and wrappers.cpp REVERT: ea0671f Tiny fix to make sure it builds. REVERT: 86ba6d1 Transaction handling begun REVERT: 73055be Added group handle to HasTable and AddTable REVERT: 1d7e4f3 Added some group- and sharedgroup methods to wrappers and unsafenativemethods REVERT: 76f8d22 Merge branch 'master' into kd-sharedgroup-basics-#23 REVERT: 3457f08 Merge pull request #54 from realm/ad-separate-solutions-#53 REVERT: 10b67a0 Realm is Handled instead of (or rather: as well as) IDisposable REVERT: 2e486a8 #53 Splitting out the solutions to be platform-specific REVERT: 7f6cc46 Group and Transaction moved to RealmNet project, added to CoreProvider. REVERT: 76ac6c4 Stop tracking Resource.Designer.cs and hide from git REVERT: 2e9c512 Delete shared group on dispose REVERT: 54436ec Added tutorial solution obj to .gitignore REVERT: 92a0a5a Dispose added to handles REVERT: 7095a88 Very basic SharedGroup implementation REVERT: 977b11e Upgrade NUnit in RealmTests, ignore failing MapTo-test REVERT: 6408f79 SharedGroup replaced with SharedGroupHandle in UnsafeNativeMethods REVERT: 91ee99c Interop.Win32 dependency on Wrappers to ensure correct build order. REVERT: d96ba84 References in native methods replaced with handles for various calls REVERT: c673405 Legacy Row class removed REVERT: 73897ac Spec and RowCell from legacy code removed. REVERT: 9ee46d4 Fix a few missing functions in UnsafeNativeMethods. REVERT: 2078399 Revert "Change file mode for a bunch of files" REVERT: 9ce2540 Change file mode for a bunch of files REVERT: 0c68bad Reference to CompilerServices in Interop.Win32 removed REVERT: 6b75b03 Group api added to wrappers.cpp REVERT: 2a72e4f InteropShared folders added to Interop.Win32 and Interop.Android REVERT: 44daca9 Remaining shared classes (Row, Table, Spec, etc.) added to Interop.Win32 REVERT: 05d32f4 CoreProvider shared between Interop projects REVERT: db919c4 Merge pull request #49 from realm/kd-win32-interop REVERT: b26f861 Removed redundant (and absolute) library path REVERT: 8750c3c Fixed absolute paths in wrappers.vcxproj REVERT: cb9b3ec Changes to autogenerated android designer files REVERT: 7e1b98a Added wrapper .lib files to gitignore REVERT: 4cf5ea1 Wrappers compile for win32 REVERT: cf8305d (VS change to an autogenerated file) REVERT: 8ae923c Win32 interop: added wrapper binary to project REVERT: c1b2b7c Wrappers compile and link on Win32 REVERT: e98fee5 Added preserve attribute to Interop.Win32 REVERT: 09d748b Merge branch 'realm' of https://github.com/Tightdb/tightdb_csharp into realm REVERT: fb499e4 iOS SafeHandle bug fixed: added PreserveAttribute to parameterless constructor REVERT: 3a537a9 #17 Add Mock CoreProvider REVERT: a27a241 Building on Windows #40 add conditions and duplicate PostBuildEvent so RealmNetWeaver.csproj platform-specific copy commands work REVERT: 2d1683b Merge branch 'realm' of https://github.com/Tightdb/tightdb_csharp into realm REVERT: 0547410 Build android wrappers fixed REVERT: f853c58 Fixing build #11 - Now building Playground for iOS on Andy's iMac - Playground.XamarinIOS.csproj - remove stray inclusion of OS/X lib libwrappers.dylib REVERT: 10e49e7 Fixing build #11 - Now building Playground for iOS on Andy's iMac - makefatlib.sh fixed path of combined lib to match project expectations "Release-ios-universal" - Playground.XamarinIOS.csproj - remove stray inclusion of OS/X lib libwrappers.dylib REVERT: 18b8845 Part of documenting new build structure #11 added config files for Doxygen to cover both all the code and just C# REVERT: b5cfaf3 Towards fixing build on other machines: #10 - makefatlib.sh just added shebang, so some runners don't complain about invalid shell scripts - make-android.sh added shebang and use path based on the standard NDK_ROOT env var REVERT: 4d49a09 query_get_column added to wrappers REVERT: 610f5d7 Wrappers linked as Android Native Library REVERT: 002e609 XamarinIOS wrapper path fix REVERT: 3189bf7 Fixed paths for android wrappers REVERT: 8a07242 make for android shell script update REVERT: 0add4d4 ios and osx handled uniformly (ish) by makefile REVERT: 8b08a74 First POC of Android wrappers working REVERT: 8052384 Android playground compiles. Does not yet work though. REVERT: b75961b Added Interop.XamarinAndroid REVERT: 536d146 RealmNet.Tests stub fixes REVERT: 9504f04 CoreQuery exchanged for QueryHandle. Interfaces added to handle classes REVERT: b6bd2f7 ICoreRow interface removed, merged into ICoreProvider REVERT: 94bf3ea Trying with unconditional use of SafeHandle instead of CriticalHandle REVERT: 5455d70 Make everything build in Xamarin Studio again REVERT: cbcfba8 (File endings commit) REVERT: b4cb830 opensdf and sdf added to gitignore REVERT: dabc950 Shared handles introduced, non-functioning Interop.Win32 project compiles. REVERT: ffe4d1d Interop.Win32 project added REVERT: 8a96ea3 More package resolution REVERT: 37187c0 Package problems for integration tests solved REVERT: 7ea6804 Big rename, step #1 REVERT: 0a43c3e Merge branch 'realm' of https://github.com/Tightdb/tightdb_csharp into realm REVERT: b9bc7fb Package updates REVERT: b6d407c .ncrunchproject added to gitignore REVERT: e7bbc35 Merge branch 'realm' of https://github.com/Tightdb/tightdb_csharp into realm REVERT: f879a32 Removed core files REVERT: 09b2e85 String query implemented REVERT: d9a8d73 gitignore updates REVERT: 7c602c4 Removed binary files from wrappers/core REVERT: f98aeec Removed packages/repository.config REVERT: 08e0685 Added readme to Tools REVERT: e8f7795 Remove packages REVERT: 3d5461e POC-query runs with new core REVERT: 69a8229 Temporary shell script for merging archives into a fat lib added REVERT: 53e6763 Playground.XamarinIOS weaves a RealmObject REVERT: 896b2a2 Interop.XamarinIOS end-to-end with new core, finally up! REVERT: 5cc2057 Removed Icons folder REVERT: b3393b3 Reorganizing solution for tests REVERT: 7b3a5ca Final unsafe native methods added REVERT: 22b5a7b Some xcode project files added. Windows files in wrappers removed. REVERT: 8e0142e Makefile experiments. Dynamic library adds main() REVERT: d1b3de2 Interop for IOS and MAC share UnsafeNativeMethods REVERT: 0299322 Gitignore xcode files REVERT: 6aaa19c Interops moved into solution folder REVERT: 0db841d Ignore built weaver in /Tools REVERT: ced3c16 Various Mono adaptations REVERT: 23d13f3 Interop.XamarinMAC experiment REVERT: 8f0e605 Interop.XamarinIOS experiment REVERT: 9451326 Wrappers: first end-to-end integration (for OSX only) REVERT: d83fe83 ... REVERT: d338ef9 Merge branch 'realm' of https://github.com/Tightdb/tightdb_csharp into realm REVERT: 2c00edd Toolset version changed to 4.0 for integration tests REVERT: b897aee Ignore userprefs REVERT: 142e79c Toolset version changed to 4.0 for integration tests REVERT: 1d4a2f2 NuGet project fixes REVERT: 9f49d8f Old files moved to tightdb/ REVERT: 17f7267 Realm subtree merged into tightdb repo REVERT: abccdb3 Integration test uses query syntax REVERT: 03901a6 More reordering REVERT: e226770 Reordering folders and names REVERT: 5cf1042 First integration test works REVERT: 7780126 Managing objects by row instead of realm+rowindex REVERT: ea882e2 Linq equalsto expression parses REVERT: 2209e71 Linq detects an equal operator REVERT: a138eb3 First Linq test succeeding REVERT: cc858bd More tests of weaving, begun IQueryable experiment REVERT: 415e2e4 coreProvider introduced, setValue woven correctly REVERT: 641c057 PCL version REVERT: a2b9237 Inject WovenAttribute REVERT: 2769021 Weaving on class POC implemented REVERT: ffe2751 First commi REVERT: 07ee010 Fix the refdoc generation REVERT: f125237 Merge pull request #9 from DennisFantoni/KnownFailRemoval REVERT: 6596be9 disabled tests known to fail, added and updated notes in asana REVERT: 8694630 added C# search code to search tests REVERT: 80048d3 changed release script to only include UnityExample and TutorialSolution REVERT: 926efe8 fixed group handle constructor bog just introduced (it was set NOT to unbind while it should actually unbind) REVERT: 6743e6b updated architecture with writeup on typed interface, and support for existing user classes REVERT: 989a778 Merge remote-tracking branch 'Tightdb/master' REVERT: 3e29367 fixed bug where base constructor was not called when empty constructores are called implicitly by interop (nonfatal bug) REVERT: 8a3eb88 Minor doc-updates. faster test. REVERT: 9fa3b39 Merge remote-tracking branch 'origin/master' REVERT: b466755 minor spelling fix. REVERT: 4d026de fixed two build errors REVERT: 04de55b Changes mostly related to an update of all asana tasks REVERT: e4ae9f8 in debug, Now reports when all objects have been unbound correctly, so that we can see that all is good in the end REVERT: 1f41f7e finished documentation REVERT: 55ffc89 all know failing unit tests now named knownfail. REVERT: 16eab1a marked failing unit tests that fail bc of things missing in core, so that if something new fails, it will stand out. REVERT: 94a342f documentation update, REVERT: c6ec1f8 removed a null reference warning in two unit tests, REVERT: 6f59e8d ClearNoCheck from protected to internal to hide it from users who might derive classes from table or view wrappers. REVERT: 149f3c7 make handles internal so that users cannot instantiate the classes (experiment) REVERT: dbaf90c Suppressing some CA2122 warnings - we know we are allowing unknown user code to indirectly call native code. That's the whole point, heh. Checked calls for exploits, don't seem to be any, as we validate all parameters higher up, bf calling on. Also suppressed a lot of warnigs that are here in the first place due to a known msft bug reg. .net35 code firing a warning that should not be fired. REVERT: 708b35a Fixed up CA2122 warnings - yes, we do have validated parametres before calling c++ stuff. (in source after inspection) REVERT: 0341ef4 Updated architecture document with class descriptions and hierachy. REVERT: f6f52e1 added documentation to the solution. REVERT: d430e3d updates to concurrency notes REVERT: 37e8833 Updated architecture documentation REVERT: e66fa36 unedited notes on out-of-band exceptions, handle recycling, finalization, concurrency REVERT: 6cec3e7 Minor changes to build howto documentation REVERT: 7b3e0f5 updated core build note REVERT: a20574d updated version numbers REVERT: ba384d2 Added new changes to .net 40 and .net 35 projects. Verified that all unit tests passes (except those that fail due to things missing in core, like table.findfirstbinary REVERT: c182d8d varios minor changes inspired by hints, visibillity, comments etc. debug64 passes all passable tests. REVERT: 88aa854 beginning the architecture document REVERT: 10d3ba0 Followed some fxcop hints: changed some variables from public values to properties changed transactionstate from byte to int32 Added finally calls to handle dispose in some handle creation methods (removing CA2000 hint). more to come Added base.dispose call in transaction (to avoid unintended re-use) REVERT: e2fed41 High level documentation completed. REVERT: 46a9af5 Added thorough detection of handle leaks to debug tests. No (zero) leaked handles detected. detection code slows debug down a little, perhaps we should change to a conditional that was not active in debug in releases. REVERT: 1042449 changes due to more testing of the criticalhandle, concurrency and finalization changes. Added more agressive cleanup of finalized objects. REVERT: d895b01 Checked against test-build from latest available core. Few updates reg. core files that has been moved to the util directory. No new errrors introduced acc. to unit tests. REVERT: e3150bd Minor bugfixes to criticalhandle classes. REVERT: ffbf32a Added parameterless constructor to most handle classes for Interop to call automatically REVERT: 7fc06a8 handle related changes done, changed tests. Testing and tweaking pending. REVERT: 408309f changed more functions to use TightDbHandle REVERT: c236710 TightDbHandle classes rewired a little bit to refactor duplicated code REVERT: 80f0ce2 more changes reg. CriticalHandle. Also the editor wanted to reformat everything withouht me noticing. REVERT: ab49365 more changes related to hardening of the binding : REVERT: 7cf435f tablegetspec CriticalHandle fixup REVERT: 6b981c1 table.findallbinary (still waiting for core) REVERT: a51a989 further changes towards avoiding out-of-band exceptions, handling concurrency on root object level and avoiding exceptions from c++ to C# REVERT: 920ebf7 updated gitignore REVERT: 36194b7 Deleted binary file that got comitted by accident REVERT: 6ec2213 updated gitignore with some new files REVERT: a78ca3c many many changes. commit to ensure backup. not all is finished. Work in progress In general : REVERT: 2b4ca72 fix bug in sharedgroup reserve REVERT: a071747 Merge branch 'Finalizer_thread_concurrency_fix' REVERT: 36decd8 small changes to finalizer fix REVERT: 18dfdaf Fix so that single threaded applications that do not use using, do not crash anymore. REVERT: 9c432cd implemented sharedgroup reserve REVERT: 60002e5 implemented call to c++ group== REVERT: 6ab430c Group.ToString implemented REVERT: fa6775d made group enumerable<Table> REVERT: db60e66 more mono related exception guards, REVERT: 6845486 increased unit test coverage, added tests that hit more c++ calls REVERT: 00bc0d7 one more ignore REVERT: fe56a67 git ignore updated after merge REVERT: 5b39706 Merge branch 'release_v0.1.2' REVERT: d541471 updated version number in c++ and C# binding code. REVERT: ffcadbf Implemented tableview_get_mixed_bool REVERT: da43cc6 more binaries ignored REVERT: 7cb2a4b Merge remote-tracking branch 'origin/release_v0.1.2' REVERT: 8a014cf improved unity tutorial REVERT: ba07fe3 Updates to examples to reflect latest changes in syntax. REVERT: a026910 also cover c++ shared group rollback REVERT: 56ce999 Updated C# ref-doc status. REVERT: 623a7a0 unit test to hit TableViewSetInt REVERT: c2e71b1 Cover c++ call TableVewSetMixedLong REVERT: 6316741 unit test TableView.GetMixedSubTable REVERT: b91ec55 Added set_mixed_subtable in c++ binding REVERT: 6d2df61 removed some time_t code that is no longer needed with new changes to core REVERT: f41803c Added ReadOnly support on all wrapped classes, ReadOnly is set on all Read Only instances, but still need to make validation calls on modifying methods, and stil need to do typecasts in c++ to ensure that const or not const methods are called where it is neccessary. Also need to create unit tests that fail due to us calling c++ in an usnsupported way. REVERT: d2f0aee corrected comments REVERT: c18534b Single threaded test case (unit test) that exposes problems with GC calling finalizers in another thread than the main thread. REVERT: 8cfe973 Implemented TableView.Sort REVERT: f688caa Implemented RowToString in TableView and Table REVERT: 2986f19 Implemented TableView Getparent() as a readonly property Parent. REVERT: 59aa173 Casing changed in a few method names. REVERT: a56e7e0 Implemented maximum and minimum datetime in table and tableview, REVERT: 40fa9d6 Implemented TableView.GetSourceNdx(long RowIndex) REVERT: 50d8da5 Added Table and Tableview ToString (default value handling, unit tests) REVERT: fdcbfba Added Table.Optimize() REVERT: fc17b71 Table.AddInt implemented REVERT: c5e049b Support for AddSubTable(.... TableView) in .net 35 (was compile build error ) REVERT: 4f25759 Added tests for row.ClearSubTable, This completes Row.SetSubTable task. REVERT: 88e415d cleanup in PerformanceTest project REVERT: e7fbbe7 changes to the customer class to have more rows and columns in each subtable. REVERT: aad6887 Updated performancetest to do more sizes and more types. REVERT: 787b0a6 Merge pull request #8 from DennisFantoni/master REVERT: ac5f84c expanded performancetest to also report memory usage. REVERT: 8447941 work in progress, finishing up tablerow.setsubtable (tests written but need to be finiashed. need testing on .35 .40 and .45 - some of the code is platform specific) REVERT: 2d27c62 Merge pull request #7 from DennisFantoni/master REVERT: a655ce9 clear.. forgot these two REVERT: 565377d Added Table.Clear and TableView.Clear. REVERT: 4e3c3c4 removed fixed path REVERT: 752baf2 minor change in build docs. REVERT: c57e69e Updated build procedure to fix two readme files that should be with windows endings in the release archive REVERT: c21adbb Tried to fix line endings for readme files that are supposed to be readable on the windows platform. REVERT: 1a94d94 Merge remote-tracking branch 'origin/release_v0.1.1' into release_v0.1.1 REVERT: 75756b2 obsolete readme removed, build note wording changed REVERT: 74e6463 Merge remote-tracking branch 'Tightdb/release_v0.1.1' into release_v0.1.1 REVERT: af77e41 updated version number in c# part REVERT: a718500 updated version number on cpp part REVERT: 299b6b0 updated to reflect change of windows build file location in core REVERT: 7d4a7fb Merge remote-tracking branch 'Tightdb/release_v0.1.1' into release_v0.1.1 REVERT: 869d2c5 small changes to install readme after having tested it on a pc w/o tightdb. REVERT: 74e627c Merge remote-tracking branch 'origin/AlphaReleaseCandidate' into AlphaReleaseCandidate REVERT: 390ebdb fixed using in unity tutorial REVERT: 279483e Merge pull request #6 from DennisFantoni/AlphaReleaseCandidate REVERT: f12b416 fixed sharedgroup unit test that did not use using. For now, You have to use using, or else your wrapper object might get concurrently GC'ed and that might lead to fatal errors as neither C# binding or core supports multiple threads running in the same object. (for instance operations on a table could be ongoing while the GC concurrently deletes a subtable taken out from that table earlier). Also removed validatetable from ObjectIdentification as OI does not call core, and is used in situations where the table is in fact not attached. REVERT: 6a129e0 changed example projects to use links to refer to the c++ dll files REVERT: 9185378 updated readme.md with more consice and up-to-date build instructions REVERT: 9ffc2e5 updated .net directories in release.cmd script REVERT: 2a4308e renamed .NET project directories to look nicer, change reflected in solution and project files. REVERT: 6d3f108 prepared examples for support for older versions of .net REVERT: e6dbb18 Change release batchfiles to create unique arhcive filenames REVERT: efc0e46 Updated release.cmd for the native dll to have date and time as part of the archive filename REVERT: be51d89 implemented GetSubTableSize in table, tableview - for subtable and mixed, inclusive passing unit tests. REVERT: 46b93d5 This version should be generally ready for release. All unit tests on .net 4.5 passes except tests exposing known bugs. Built with breaking updates as of saturday 2013-10-06 so includes new query find syntax. No unexpected warnings or hints. VS2012 mouseover help on all public methods. More unit tests need to be run and examples need to be checked, but wait until we are sure breaking updates is final. REVERT: 7ad5d6f Merge remote-tracking branch 'origin/master' REVERT: d3416d9 Adding gititgnore to the solution, so many files need to be ignored REVERT: a11f301 query.find implemented with new meaning of the parameter. REVERT: ae5231e table->find_first_binary throws - change dll method to return 0 when it throws (so when core gets fixed stuff will work automatically). REVERT: 51155db Merge remote-tracking branch 'origin/master' REVERT: e56cf99 Table and tableview find all, work in progress, commit so I can work on it at home REVERT: 6340419 Merge pull request #5 from kneth/master REVERT: f1521ab Merge branch 'master' of github.com:Tightdb/tightdb_csharp REVERT: 1f8587a changes related to getting ready to release, REVERT: e23cd29 Moving the tutorial. REVERT: 2ad0614 Merge pull request #4 from kneth/master REVERT: 98345e6 Create empty/dummy documentation for C#. REVERT: 9d2a8ec Merge branch 'master' of github.com:Tightdb/tightdb_csharp REVERT: 0240f48 work around mono problem with cpp exceptions REVERT: 73080f0 Minor changes in tutorial for more compact view REVERT: eed0c0c Various issues related to running on .net v 3.5 fixed REVERT: 212a457 Merge remote-tracking branch 'origin/master' REVERT: d65db21 new tutorial overlay and tutorial file for docs. Major reorganization of file structure to allow for several projects targetting various platforms. Added support for mono 3.10 and mono 2.10, and .net 4.0 added a commandline unit test runner not dependent on having nunit installed. commandline test runner support for mono 3.01 mono 2.10 and .net 4.0 Major changes : libsVS2010 and libsVS2012 moved down into native folder. removed more windows stuff from c++ dll. removed cout calls in dll. changed .cmd files to reflect changes in location of libsvs20nn. Added guards around .net 4.5 specific code. Improved showVersion to tell more about stuff that differs between mono and .net. prettified showVersion output. Minor changes in Query exception handling in an attempt to locate a bug that was in fact inside NUnitLite. Reorg is work-in-progress. REVERT: 9949405 Merge pull request #3 from kneth/master REVERT: e8dae37 Linux has case sensitive file names REVERT: a3a0adb changes to make binding work with mono/Windows. REVERT: 5c40047 new csharp overlay.txt file REVERT: 55edc87 updated tutorial.cs. Now it contains a running tutorial with all features enabled. REVERT: e40c52e fixed all 103 resharper issue hints (except 2 that show because of missing methods implemented in the dll) REVERT: b1501de This commit: Removes all updating functionality from Spec, and adds similar functionality to Table. Followup changes to validation and unit tests. Syntax improvements regarding handling of subtables. more extensive testing of path based modifications. removes validation and bookkeeping that was in the binding, to make sure a user could not call updatefromspec at a time where such a call would be invalid. Removed updatefromspec altogether. REVERT: 9ebf55d RowColumn filename renamed to RowCell REVERT: 52e4ed7 implemented vectorized AddSubcolumn, RemoveSubcolumn and RenameSubColumn. (c++, c#, unit tests, validation) REVERT: 4fdba11 Added support for more core methods. added unit tests, bugfixes, warnings and resharper hints fixes. REVERT: 9d50fd8 tableview set,get mixed binary implemented in c++ dll. tableview set,get mixed binary in C#. find first binary implemented but throws as it is not in core yet (in core it throws not implemented yet). Visibillity of a lot of methods tighthened. Row (cursor) few missing mixed getters and setters implemented. Removed TableException and rewrote to use standard C# exceptions instead. Transaction state never removed (was never used, we can do with a two-value state). setmixed returns early to avoid perhaps evaluating the same value twice. Should also make it somewhat faster. unit testes for row set and get. shared group transaction unit test and example expanded a little bit for clarity. added few methods to various unit tests to increase coverage of these methods from 0 to 1. Datetime unit tests that detail the use of DateTime.DateTimeKind, and makes sure we can round trip correctly. Also some text and links to clarify things a bit. Unit test for setmixedbinary and getmixedbinary. All this part of an ongoing cleanup and reduce number of small outstanding tasks operation. 141 of 142 unit tests pass, the failing one is a core issue, not a binding issue as such. (how can binding be sure its okay to call spec.addfield?) REVERT: 3abaeac created in c++ dll : Table get mixed binary and set mixed binary. table has index. tabelview to json. in c#: New debug code that shows path and filename of actual dll file loaded. Spec wrappers now know what root table wrapper they are connected to. Spec exception removed entirely, using more generic exceptions instead. table get/set mixed binary, table.HasIndex. Various small improvements all over, indicated by Resharper hints. Table.HasColumns now is false until updatefromspec has been called. Used to stop user from doing modifying spec operations on a table with columns. fixed group bug where user could specify a table definition that was an empty list. typed methods for creating fields in spec. Added public SpecModifyable to table, so that a user can investigate if it is safe to start an update operation (blabla column followed by updatespec). Validation that a user does not modify table structure on a non-mixed subtable spec. table insert row and table insert(rowid,data) coded. table.insertemptyrow. table.distinct with validation that the column index points to a indexed string column and nothing other than that. some tidying up after some earlier debugging. add improved to also be able to take an int[] array if all columns are int columns (due to the way C# interprets constant arrays where the type is not obvious from contents). unit test project getdll.cmd now copies 64 bit dll to a 32bit debug dir, bc the stupid unit test viewer sets the current directory in the wrong place in some cases. unit tests for all the above and some more. All unit tests pass, except one corner case that is not passing bc it would need core support to handle that specific situation. REVERT: 90457dd New console project called Test that can call into the unit tests, but with a console window attached for debugging purposes REVERT: eb0c7c3 examples now include shared group support. REVERT: 4d9b5b4 implemented all of shard group, as well as unit tests that tests basic usecases and a few error cases. Not finished, but will work fine as long as You don't do something really weird. few small .cmd file changes for the release scripts. Changes to group to acommodate it being subclassed into transaction (dispose system was not prepared for the situation where a group handle should not be disposed, but a transaction should be rolled back). Introduced Transaction class (subclasses Group as in the Java binding). Changed a test in table to avoid a bug in c++ core (set index followed by addemptyrow). Added a table test that showcases a bug in table.add(). Added a bunch of compiler generated files to gitignore. REVERT: 92e353a more stuff works. old test solution split up into examples and a new unit test project inside the solution. many methods added. new dll build with new c++ core version. speed test added. now built with vs2012 update 3. all 97 unit tests passes x64 , x86 , debug and release REVERT: fb98842 release_all.bat changed, now creates examples.zip correctly, also fixed bug when examples\lib was not there the very first time it was run after a fresh checkout. REVERT: d57b0a6 new release_all.bat that runs release on all c# binding parts, and then updates the examples dir and creates a new examples.zip. updated version of examples.zip untested but newer. More silent build.bat for the c# part. REVERT: 4703b78 Major rewrite and update of readme files everywhere, so they resemble current status of build and deployment. Small changes throughout to reduce code analysis warnings and resharper warnings to nothing (except for places where it makes sense, e.g. empty methods for BinaryData that needs to be coded). Removed most debug stuff reg. the bug in core groups, as well as the bug that was caused by me missing a TIGHTDB_DEBUG setting in a c++ dll build setup. Removed optional parametres as per MSFT suggestions (acc. to msft standards, compilers of .net languages do not have to initialize optional parametres to their stated default values, so a library that might be used in such a language ought not to have any optionals visible by users of that library). This commit has not been unit tested or tested on a fresh install, so might need a little tweaking. also, the example.zip file has not been updated. (will do only as part of a unit tested release). changed group using code to reflect new file error reporting, also in tutorial. REVERT: cf49e0d New example tutorial project source, now built for a dynamic c# example, much like the python one. overlay.txt not done yet. REVERT: 6e94ce5 Added indexing to Row. It now returns an object resembling the value of the column of the index - it recieves an object and puts its value into the column of the index. the real type of the object is checked to see if it is compatible. REVERT: 15b368b changed tightdb_c_cs2012 to more closely match the lib c++ setup. changed many settings throughout the 4 configurations. experimented with teststuff project looking for errors, added TIGHTDB_DEBUG. removed 7z as it is not needed more than one place. work in progress reg. splitting tutorialdynamic up into an experimental and a tutorialdynamic to be used for documentation. change hardcoded group file to a temp file to ensure write rights in unit test. moved comments to where the code had moved, implemented a dynamic version of last (row and tableview), work in progress (ought to match back() reg. use of an optional parameter for offset). looks like resharper fixed up the code formatting in tableorview. most major imrovement is that the allocator or group bug is now gone bc the c++ dll is set up exactly as the lib file. REVERT: ef185ce deleted .rar file , added .zip file. REVERT: a9969da Examples archive. Unzip this in any diretory and open TutorialSlution\TutorialSolution.sln in Visual Studio - click Start to run the tutorial. Everything is pre-setup to make the tutorial run with no setup or installation required. REVERT: 4e09105 work in progress reg. build batch files and release generation. REVERT: 419bd41 syntax experiments, commit to move them between pcs REVERT: 7de66b9 experiment with += operator overload (no changes) REVERT: 9bcdd90 changed object declarations to new more concise syntax REVERT: cb97ef0 work on documenting the last few lacking c++ table and tableview methods. REVERT: 2e29361 this is what goes into the first alpha-release of the C# binding REVERT: 84705e8 table_has_shared implemented and unit tested. rename of IsValid to TableIsValid in c++ and native calls REVERT: 799ab0b table is now ICloneable. copy table, table_valid, clear_subtable. Unit tests made in the hunt for a tightdb core error (clone and column names).. fixed bug reg. setting a row with a null for a subtable (now creates a new subtable instead of leaving the old one there). commit to allow me to work on this at another computer. all unit tests pass, except unit tests that fail bc of errors in core (selected tests concerning group and clone) REVERT: b6cb42e readme file in a directory to get it included into git REVERT: 7342bbb Changed teststuff c++ project files in order to try to build with newest tightdb libraries. Debug x64 still not working (link errors). the other 3 are working. the 4 DLL projects are working REVERT: 331601d All StringData usage works, UTF-16 characters fully supported. All unit tests passes both 32 and 64 bit. Errors in Group unit tests can be replicated in pure c++ code so is not a C# issue. Added TestStuff c++ project in native solution to have a template to create c++ projects to check if a problem is on the c++ side or the c# side. Fixed some type errors in table/view sumfloat, it now returns double, not float. type errors made a unit test not work in 32bit, but work in 64bit. Write handle pointers to console as hex when debugging. REVERT: ae70332 c++ methods that recieve strings changed to handle new string passing methology (ptr to UTF-16 plus a size_t length indicator). Not finished yet, commit to allow me to continue work on another pc. REVERT: 614d76d now UTF8 to UTF16 is handled in c++. Now StringData is used. Strings are sent back to C# using a simple buffer instead og Stringbuilder. Support for null chars in strings. Still work in progress, needs more testing. UTF16 to UTF8 is also work in progress c# to c++ still being coded. this commit will not work very well until string stuff is finished and tested. REVERT: 17a51da removed group stuff from tutorial test until we run with the newest c++ build REVERT: d80cf11 temporary try at fixing group filename problems with old tdb build REVERT: c3abdb8 start end limit validation refactored out to be used by both query.count and query.findall REVERT: f225265 Now handles if end is specified larger than sourcetable.size in query.findall(start,end,limit). Before end was passed on without checking against sourcetable size, and that led to tightdb looping forever if user specified end>=Size. REVERT: 72303c0 Validation in query's columnId(string) function. REVERT: 093b642 Merge branch 'master' of github.com:Tightdb/tightdb_csharp REVERT: 190dc64 uncomment REVERT: 5a29a64 testdynamictable unit test, fixed bug that used the wrong table REVERT: 728214a Merge branch 'master' of github.com:Tightdb/tightdb_csharp REVERT: d63c3a7 vs2012 automatically removed HasPerformanceSessions=true. REVERT: 26012d8 suo. not even sure what changed REVERT: f08e586 table_sum_float returns float now. (typeing mistake) REVERT: 343aef1 fixed json interop bug. REVERT: a3ed8ae changed by vs REVERT: d2990ea added app.config for unit test project REVERT: 23ce4f3 fixed hard directory path in project file REVERT: 6428313 more c++ solution files REVERT: 78a6e3a c++ solution files REVERT: 7d11619 work in progress reg. project files and a new setup based on a more or less standardized windos vs2012 build. REVERT: 5580957 Implemented all aggregates from table and tableview. implemented more of the java dynamic table example. REVERT: e386ebd implementing dynamic table example. validation added to table.renamecolumn. added table.removecolumn. table.set ( array of data) table.setmixed bool, string, binary. set mixed from object now handles ints in objects. tableorview setmixedbool , setmixedstring , binary, bool, subtable. (binary not implemented fully yet). remove refactored, removelast() added, calls remove. tableview set mixed bool, string, binary. call to c++ tableremovecolumn. call to c++ table_insert_empty_row, calls to table, tableview set mixed string, bool. c++ implemented table_rename_column, remove_column, set mixed string,bool, insert empty row. fixed a bug in table or tableview setfloat REVERT: e705306 fixed bug in setfloat (wrong return type for the function) REVERT: a6ae51b added few tests as unit tests. fixed up warnings from code analysis, changed functions that return tables to dispose table if exceptions are thrown before the table is ready to be returned. Group gettable and group hastable instead of just gettable. removed some console writelines. QueryAverage finished.code analysis supressmessages moved to file from source to reduce clutter. asana updated with TODO's. TODO's changed to TODO or IDEA depening on what it is. Added short note why the ienummerables Table , TableView and Qery are not named blablaCollection as they often are in C#. changed a nested if in field to switch to make it eaiser to read. Implemented tableviewsetfloat and prom…
nirinchev
added a commit
that referenced
this pull request
Jan 9, 2019
* Bump Sync to 3.10.1 * Try to disable the sync win32 build * Update ROS for tests * Try to enable the ROS tests * Update to latest OS, sync, and Core * Update new core linux location * Bring back the windows builds on CI * Remove the withROS_temp * Changelog * Remove some .def files * Try to set nuget environment variable * Try #2 * Try #3 * Try #4 * #5 * #6 * Report the node * Upgrade to 3.14.11 * Use the well-known sync binary location * Try to fix the tests * Fix the changelog * Update CHANGELOG.md Co-Authored-By: nirinchev <irinchev@me.com> * Update CHANGELOG.md Co-Authored-By: nirinchev <irinchev@me.com> * Update CHANGELOG.md Co-Authored-By: nirinchev <irinchev@me.com> * Changelog updates
nirinchev
added a commit
that referenced
this pull request
Apr 9, 2021
* wip * Supply input and output paths to the action * Add ncc * Fix the action metadata * Tweak the build wrappers command * Try to simplify configuration passing to bash builds * Bump down ubuntu version for android * Try and use ytt for templates * Remove the `null` from PR * Try #3 * Try #4 * Try 5 * Try 6 * Try to use pure workflow * Remove extra brace * Yet another brace * cacheKey -> key * Add the cache condition to any intermediate steps * Revert files that are unrelated to the workflow change * More tweaks to the template * Test building iOS wrappers * Try to build iOS #2 * Bring back the cmake configuration check in ios and android build scripts * Try building linux on bare metal * Use correct ubuntu image * Try to add Android * Put matrix under strategy * Setup NDK env variables * Add $ * Don't download the ndk * Added windows to templates * Try to cache vcpkg * Trigger uncached build * Trigger another uncached build * Another build * Another uncached run * Revert dummy changes * Added UWP to template * Fixed small detail * Added saving output * Always output cacheKey from building wrappers * Removed TODO comment * Ac/retrieve multiple caches ga (#2325) * Added fetching multiple bins * Store binaries as artifacts * Store binaries as artifacts - 2 * Store binaries as artifacts - 3 * Store binaries as artifacts - 4 * Store binaries as artifacts - 5 * PR ready for review Co-authored-by: Andrea Catalini <andrea.catalini89@gmail.com>
nirinchev
added a commit
that referenced
this pull request
Apr 9, 2021
* First action attempt * Wrong path to action * Renamed action * Sadly the action is brought back to do 1 thing only * Some mispelling * Created JS action to build wrapper * Renamed folder in main.yml * Reshuffled things * Hopefully nodejs 14 and not 12 * Few fixes * Removed nodejs 14 stuff * All compacted into index.js * First iteration of build_wrappers action * Added some info text * Forgot to update action path * Moved from core.debug to core.info * Updated string to use template literals * Correct error to return success * Forgot to build * I like it more with the dash * Forgot to build again * Fixed some checks on string content * Build forgotten * Live output for built cmd + removed exit code when error * Reverted to cp.exec * Better output folding * Check for error at caching * Some fixes + lots of prints * Changed from exec to spawn * Try to fix spawn and env var * Small improvements * Async method should now be fixed * Final test to check correctness * Small code style changes * First attempt at making caching and building general * Forgotten meta build action * Fixed some mispelling in commands in main * Refactored lots of stuff * Json in 1 line in main.yml workflow * Added test framework, added tests for input parsing, split utils in multiple files * Added a TODO and better logging in spawned child * Removed hash options, it doesn't seem necessary * Unit test added for all common functionalities * Extracted main functionalities from action * Updated action.yml name and description * Folder rename * Small cleanup main.yml * Extrapolated core code in it's own folder * Forgotten to change path to action in workflow * Fix path for action * This time path to action should be fixed * Minor fixes * Temporary test with external repo for core code * Just a test with types in lib * Small error correction * Test with checkout action * Attempt moving checkout js in same dist of build_executor * Test with double checkout * Postponment of checkout action inclued * Fixed some wrong build command * Added package folder (lib) and changed input parsing for paths * Updated path to packages in main * Added optional hash prefix * HashKey used as index by the cache function is now returned as output * Cmds in input aren't anymore a json array of json objects * Reshaped tasks.json, added scripts in package.json and updated structure in packages * Eslinter and prettifier setup and run * Removed result struct and reintroduced exceptions * As far as I can go with the linter * Made utils internal, linted and prettified action * Final adjustments for PR review * Added one more test to check prefix on hash * Fixed wrongly passed hash prefix * Returned wrong value from main * Some rephrasing * Improved comments * Added settings for debugging source code and tests * Reshaped hashing function to better account json structure + improved test speed on hashing test * Rephrased a log * Final minor corrections before PR review * Forgotten to build and lint/prettify * Better fail message * Improved input_parsing and expanded tests * More unit testing, more safety checks and few other minor changes * Fixes for the GA package (#2306) * Add typescript to dependencies * Add some basic eslint rules (will extend later) * Add typings to package.json * Add __tests__ to tsc includes * Disable the unused var warnings for tests * Indent code with 4 spaces (#2307) * Indent code with 4 spaces * Increase print-width * Simplified according to PR review * Fixed input in action * Compacted code in only 1 file * Added options to debug typescript files directly * Forgot to remove a comment * Migrate GA to a pure workflow (#2322) * wip * Supply input and output paths to the action * Add ncc * Fix the action metadata * Tweak the build wrappers command * Try to simplify configuration passing to bash builds * Bump down ubuntu version for android * Try and use ytt for templates * Remove the `null` from PR * Try #3 * Try #4 * Try 5 * Try 6 * Try to use pure workflow * Remove extra brace * Yet another brace * cacheKey -> key * Add the cache condition to any intermediate steps * Revert files that are unrelated to the workflow change * More tweaks to the template * Test building iOS wrappers * Try to build iOS #2 * Bring back the cmake configuration check in ios and android build scripts * Try building linux on bare metal * Use correct ubuntu image * Try to add Android * Put matrix under strategy * Setup NDK env variables * Add $ * Don't download the ndk * Added windows to templates * Try to cache vcpkg * Trigger uncached build * Trigger another uncached build * Another build * Another uncached run * Revert dummy changes * Added UWP to template * Fixed small detail * Added saving output * Always output cacheKey from building wrappers * Removed TODO comment * Ac/retrieve multiple caches ga (#2325) * Added fetching multiple bins * Store binaries as artifacts * Store binaries as artifacts - 2 * Store binaries as artifacts - 3 * Store binaries as artifacts - 4 * Store binaries as artifacts - 5 * PR ready for review Co-authored-by: Andrea Catalini <andrea.catalini89@gmail.com> * Remove the typescript action (#2326) * remove some leftovers * Remove process.sh Co-authored-by: Nikola Irinchev <irinchev@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DennisFantoni