Indent code with 4 spaces #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
ni/ga-fixes
to
ac/build-macos-wrappers-github-actions
March 25, 2021 00:24
nirinchev
force-pushed
the
ni/ga-fixes-indent
branch
from
14a7bbb
to
ff96156
Compare
nirinchev
added a commit
that referenced
this pull request
Apr 9, 2021
* First action attempt * Wrong path to action * Renamed action * Sadly the action is brought back to do 1 thing only * Some mispelling * Created JS action to build wrapper * Renamed folder in main.yml * Reshuffled things * Hopefully nodejs 14 and not 12 * Few fixes * Removed nodejs 14 stuff * All compacted into index.js * First iteration of build_wrappers action * Added some info text * Forgot to update action path * Moved from core.debug to core.info * Updated string to use template literals * Correct error to return success * Forgot to build * I like it more with the dash * Forgot to build again * Fixed some checks on string content * Build forgotten * Live output for built cmd + removed exit code when error * Reverted to cp.exec * Better output folding * Check for error at caching * Some fixes + lots of prints * Changed from exec to spawn * Try to fix spawn and env var * Small improvements * Async method should now be fixed * Final test to check correctness * Small code style changes * First attempt at making caching and building general * Forgotten meta build action * Fixed some mispelling in commands in main * Refactored lots of stuff * Json in 1 line in main.yml workflow * Added test framework, added tests for input parsing, split utils in multiple files * Added a TODO and better logging in spawned child * Removed hash options, it doesn't seem necessary * Unit test added for all common functionalities * Extracted main functionalities from action * Updated action.yml name and description * Folder rename * Small cleanup main.yml * Extrapolated core code in it's own folder * Forgotten to change path to action in workflow * Fix path for action * This time path to action should be fixed * Minor fixes * Temporary test with external repo for core code * Just a test with types in lib * Small error correction * Test with checkout action * Attempt moving checkout js in same dist of build_executor * Test with double checkout * Postponment of checkout action inclued * Fixed some wrong build command * Added package folder (lib) and changed input parsing for paths * Updated path to packages in main * Added optional hash prefix * HashKey used as index by the cache function is now returned as output * Cmds in input aren't anymore a json array of json objects * Reshaped tasks.json, added scripts in package.json and updated structure in packages * Eslinter and prettifier setup and run * Removed result struct and reintroduced exceptions * As far as I can go with the linter * Made utils internal, linted and prettified action * Final adjustments for PR review * Added one more test to check prefix on hash * Fixed wrongly passed hash prefix * Returned wrong value from main * Some rephrasing * Improved comments * Added settings for debugging source code and tests * Reshaped hashing function to better account json structure + improved test speed on hashing test * Rephrased a log * Final minor corrections before PR review * Forgotten to build and lint/prettify * Better fail message * Improved input_parsing and expanded tests * More unit testing, more safety checks and few other minor changes * Fixes for the GA package (#2306) * Add typescript to dependencies * Add some basic eslint rules (will extend later) * Add typings to package.json * Add __tests__ to tsc includes * Disable the unused var warnings for tests * Indent code with 4 spaces (#2307) * Indent code with 4 spaces * Increase print-width * Simplified according to PR review * Fixed input in action * Compacted code in only 1 file * Added options to debug typescript files directly * Forgot to remove a comment * Migrate GA to a pure workflow (#2322) * wip * Supply input and output paths to the action * Add ncc * Fix the action metadata * Tweak the build wrappers command * Try to simplify configuration passing to bash builds * Bump down ubuntu version for android * Try and use ytt for templates * Remove the `null` from PR * Try #3 * Try #4 * Try 5 * Try 6 * Try to use pure workflow * Remove extra brace * Yet another brace * cacheKey -> key * Add the cache condition to any intermediate steps * Revert files that are unrelated to the workflow change * More tweaks to the template * Test building iOS wrappers * Try to build iOS #2 * Bring back the cmake configuration check in ios and android build scripts * Try building linux on bare metal * Use correct ubuntu image * Try to add Android * Put matrix under strategy * Setup NDK env variables * Add $ * Don't download the ndk * Added windows to templates * Try to cache vcpkg * Trigger uncached build * Trigger another uncached build * Another build * Another uncached run * Revert dummy changes * Added UWP to template * Fixed small detail * Added saving output * Always output cacheKey from building wrappers * Removed TODO comment * Ac/retrieve multiple caches ga (#2325) * Added fetching multiple bins * Store binaries as artifacts * Store binaries as artifacts - 2 * Store binaries as artifacts - 3 * Store binaries as artifacts - 4 * Store binaries as artifacts - 5 * PR ready for review Co-authored-by: Andrea Catalini <andrea.catalini89@gmail.com> * Remove the typescript action (#2326) * remove some leftovers * Remove process.sh Co-authored-by: Nikola Irinchev <irinchev@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Indents code with 4 instead of 2 spaces.