[WIP] Return unique JS objects if they have a primary key #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,6 +60,9 @@ ObjectSchema::ObjectSchema(const Group *group, const std::string &name) : name(n | |||
| } | |||
|
|
|||
| Property *ObjectSchema::property_for_name(StringData name) { | |||
| if (!name.size()) { | |||
There was a problem hiding this comment.
Yep, when primary_key_property() method is called on a schema without a primary key.
|
retest this please |
This implementation does not yet handle the case where the primary key is changed on an object.
appden
force-pushed
the
sk-unique-objects
branch
from
aa9c8be
to
0862e0b
Compare
This was referenced Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation does not yet handle the case where the primary key is changed on an object. This would mostly resolve #19, since we can't completely resolve it without having unique object ids.