Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Fix #433 In Podfile enable Cocoapods to get Cartography 3.0.1. Fix build errors. #436

Open
wants to merge 13 commits into
base: to/swift4
Choose a base branch
from

Conversation

beepscore
Copy link

@beepscore beepscore commented Nov 29, 2017

In terminal, "pod install" prints warning.
"To avoid issues in the future, you should not use TextEdit for editing it. If you are not using TextEdit, you should turn off smart quotes in your editor of choice."
Apparently accidentally introduced in commits 5a743a2 and 6b6c0fe.

…your Podfile."

In terminal, "pod install" prints warning.
"To avoid issues in the future, you should not use TextEdit for editing it. If you are not using TextEdit, you should turn off smart quotes in your editor of choice."
Apparently accidentally introduced in commits 5a743a2 and 6b6c0fe.
@beepscore beepscore changed the title Fix Cocoapods warning "[!] Smart quotes were detected and ignored in … Fix #433 In Podfile enable Cocoapods to get Cartography 3.0.1. Also change smartquote. Nov 29, 2017
@beepscore
Copy link
Author

I upudated Podfile and got Cartography version 3.0.1 but am not sure how to test this PR.
Hopefully @dhmspector or someone else can help check this change.

@beepscore beepscore changed the title Fix #433 In Podfile enable Cocoapods to get Cartography 3.0.1. Also change smartquote. Fix #433 In Podfile enable Cocoapods to get Cartography 3.0.1. Fix build errors. Nov 29, 2017
@beepscore
Copy link
Author

beepscore commented Nov 29, 2017

Should branches to/swift4 and beepscore-swift4 be considered obsolete?
master branch commit 1442fb5:
- Podfile specifies RealmSwift ~> 3
- Podfile mentions branch to/swift-4
- has many Apple related commits not in branches to/swift4 and beepscore-swift4

git merge --no-commit --no-ff master showed many potential merge conflicts.
If goal is to use Cartography 3.0.1, perhaps it would be easier to re-do, branching off current master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant