Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: run command failure with no input files #342

Closed
tiborsimko opened this issue Jan 7, 2020 · 2 comments
Closed

cli: run command failure with no input files #342

tiborsimko opened this issue Jan 7, 2020 · 2 comments

Comments

@tiborsimko
Copy link
Member

When a workflow does not contain any particular input files, as is my small CVMFS test example:

$ can reana.yaml
workflow:
  type: serial
  resources:
    cvmfs:
    - unpacked.cern.ch
    - cms.cern.ch
  specification:
    steps:
      - environment: 'cern/slc6-base'
        commands:
        - ls -l /cvmfs/cms.cern.ch/ > output2.txt

Then this workflow can be started properly by doing:

$ reana-client create -w cvmfs
$ reana-client start -w cvmfs

but not via run command:

$ reana-client run -w cvmfs
...
  File "/home/simko/.virtualenvs/reana/lib/python3.8/site-packages/reana_client/cli/utils.py", line 59, in wrapper
    return func(*args, **kwargs)
  File "/home/simko/.virtualenvs/reana/lib/python3.8/site-packages/reana_client/cli/utils.py", line 32, in wrapper
    return func(*args, **kwargs)
  File "/home/simko/.virtualenvs/reana/lib/python3.8/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/simko/.virtualenvs/reana/lib/python3.8/site-packages/reana_client/cli/files.py", line 247, in upload_files
    for filename in filenames:
TypeError: 'NoneType' object is not iterable

It would be good to fix the None iteration exception.

@tiborsimko tiborsimko added this to Ready for work in Awesome-Workshop-Basics Jan 7, 2020
roksys pushed a commit to roksys/reana-client that referenced this issue Jan 7, 2020
@roksys roksys self-assigned this Jan 7, 2020
@roksys roksys moved this from Ready for work to In work in Awesome-Workshop-Basics Jan 7, 2020
@roksys roksys moved this from In work to In review in Awesome-Workshop-Basics Jan 8, 2020
@tiborsimko
Copy link
Member Author

Looks good, but I think you haven't made a PR yet?

@tiborsimko
Copy link
Member Author

Looks good, but I think you haven't made a PR yet?

Ah, I see it is a part of the other-titled PR #344 ... OK.

Awesome-Workshop-Basics automation moved this from In review to Done Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants