Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: sets default notebook to jupyter #344

Merged
merged 2 commits into from Jan 8, 2020

Conversation

roksys
Copy link
Contributor

@roksys roksys commented Jan 7, 2020

No description provided.

@roksys roksys added this to In work in Awesome-Workshop-Basics Jan 7, 2020
@roksys roksys moved this from In work to In review in Awesome-Workshop-Basics Jan 7, 2020
@@ -303,7 +303,7 @@ environment spawned on the remote containerised platform.

.. code-block:: console

$ reana-client open -w myanalysis.1 jupyter
$ reana-client open -w myanalysis.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not sure about removing "jupyter", since "open -w myanalysis.42" can give an impression that this will open the web page for the given analysis, which we don't have yet but which will come. It'll be good to keep the option open to use "open" without qualifier to point to the future reana.cern.ch/myanalysis/42 page with workflow details.

This is akin to "hub" command-line client where "hub browse" opens the GitHub repository web page; similarly "reana-client open" can in the future open the REANA web page for the given workflow run.)

Perhaps revert back to having "jupyter" mandatory in order not to loose this possibility?

@@ -868,6 +868,7 @@ def interactive_group():
@click.argument(
'interactive-session-type',
metavar='interactive-session-type',
default=INTERACTIVE_SESSION_TYPES[0],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since close closes jupyter, but default, I guess we can go with it, but there might be changes ahead later.

@tiborsimko tiborsimko merged commit ec6c05a into reanahub:master Jan 8, 2020
Awesome-Workshop-Basics automation moved this from In review to Done Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants