cli: add analysis seeding option #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegodelemos
commented
Oct 11, 2017
| @@ -1,182 +1,246 @@ | |||
| { | |||
| "definitions": {}, | |||
| "definitions": {}, | |||
There was a problem hiding this comment.
@hjhsalo do you remember something related with trailing spaces when generating OpenAPI specs? it rings a bell that you solved it or you know how to solve it.
For some reason RS does it but RWC does not and the diff shows nothing. It is just a quick question if you don't remember straight away I will find out 🙃
$ diff ~/reana/reana-server/scripts/generate_openapi_spec.py \
~/reana/reana-workflow-controller/scripts/generate_openapi_spec.py
38c38
< __title__ = "REANA Server"
---
> __title__ = "REANA Workflow Controller"
41c41
< __api_description__ = "Submit workflows to be run on REANA Cloud"
---
> __api_description__ = "Submit and manage workflows"
diegodelemos
force-pushed
the
seed-analysis
branch
3 times, most recently
from
2cd4c7e
to
4a31a1d
Compare
hjhsalo
approved these changes
Oct 18, 2017
|
For reana_client/api/client.py#L45 see comment in reana-server/pull/11 |
* Adds a redundant field `file_name` since bravado client doesn't propagate the file name. Waiting for Yelp/bravado-core#201 to be implemented. Signed-off-by: Diego Rodriguez <diego.rodriguez@cern.ch>
diegodelemos
force-pushed
the
seed-analysis
branch
from
4a31a1d
to
26ee176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Diego Rodriguez diego.rodriguez@cern.ch