-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add seeding endpoint #11
Conversation
0b6bd02
to
55d43b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments of style and language used. Nothing that prevents merging so, LGTM
Disclaimer: Just reviewed code. Didn't test with live REANA Cluster.
reana_server/rest/analyses.py
Outdated
post: | ||
summary: Seeds the analysis workspace with the provided file. | ||
description: >- | ||
This resource expects a file to be placed in the analysis workspace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
This resource expects a file that is to be placed in the analysis workspace identified by the UUID analysis_id.
(to be placed --> is to be placed)
This is not really part of the PR but in reana_server/api_client.py#L35 there is:
It is PEP8-compliant, but I missed the
or
|
Maybe change this in reana_server/rest/analyses.py#L115:
(informations --> information) |
In reana_server/rest/analyses.py#L33:
Term all analyses is not very clear. Or maybe it can be opened in the description part just below this one. Are there more states for an analysis than running, finished, waiting? |
1b00ec2
to
938c7ba
Compare
* Adds a redundant field `file_name` since bravado client doesn't propagate the file name. Waiting for Yelp/bravado-core#201 to be implemented. Signed-off-by: Diego Rodriguez <diego.rodriguez@cern.ch>
Signed-off-by: Diego Rodriguez <diego.rodriguez@cern.ch>
938c7ba
to
62300ad
Compare
Signed-off-by: Diego Rodriguez diego.rodriguez@cern.ch