docs: install only docs required dependencies for RTD build #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthS007
requested review from
audrium,
diegodelemos,
mvidalgarcia and
tiborsimko
mvidalgarcia
reviewed
Oct 9, 2020
| @@ -4,4 +4,5 @@ | |||
| # REANA is free software; you can redistribute it and/or modify it | |||
| # under the terms of the MIT License; see LICENSE file for more details. | |||
|
|
|||
| -e .[all] | |||
| -e .[docs] | |||
| -e .[kubernetes] | |||
There was a problem hiding this comment.
Question: Why is kubernetes necessary to generate docs?
There was a problem hiding this comment.
@mvidalgarcia There was a warning in the last step of build when I didn't include kubernetes
WARNING: autodoc: failed to import module 'api_client' from
module 'reana_commons.k8s'; the following exception was raised:
No module named 'kubernetes'
After including kubernetes, Build passed without any warning.
There was a problem hiding this comment.
When you rebased against maint-0.7, please delete all the extra commits this brought, and keep only yours.
tiborsimko
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #210