Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: install only docs required dependencies for RTD build #212

Merged
merged 1 commit into from Oct 9, 2020
Merged

docs: install only docs required dependencies for RTD build #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/requirements.txt
View file
Open in desktop
Expand Up @@ -4,4 +4,5 @@
# REANA is free software; you can redistribute it and/or modify it
# under the terms of the MIT License; see LICENSE file for more details.

-e .[all]
-e .[docs]
-e .[kubernetes]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why is kubernetes necessary to generate docs?

Copy link
Member Author

@ParthS007 ParthS007 Oct 9, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvidalgarcia There was a warning in the last step of build when I didn't include kubernetes

WARNING: autodoc: failed to import module 'api_client' from 
module 'reana_commons.k8s'; the following exception was raised:
No module named 'kubernetes'

After including kubernetes, Build passed without any warning.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you rebased against maint-0.7, please delete all the extra commits this brought, and keep only yours.