rest: simplify disk usage format #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegodelemos
force-pushed
the
rs-296/simplify-du
branch
4 times, most recently
from
86f6af5
to
45bdcd5
Compare
diegodelemos
force-pushed
the
rs-296/simplify-du
branch
from
2257b8d
to
2233ff7
Compare
mvidalgarcia
approved these changes
Oct 23, 2020
diegodelemos
force-pushed
the
rs-296/simplify-du
branch
from
2233ff7
to
0294f67
Compare
|
Moderate: Fails when we have users with no limits, the key doesn't exist, because we don't calculate the health. Works when users have limits set: $ flask reana-admin quota-usage
ID EMAIL CPU-USED CPU-LIMIT DISK-USED DISK-LIMIT
00000000-0000-0000-0000-000000000000 jdoe@example.org 89922 90000 1060 90000 |
|
To get this going I've changed the implementation so when there is no |
diegodelemos
force-pushed
the
rs-296/simplify-du
branch
from
0294f67
to
b08e425
Compare
reana_server/reana_admin.py
Outdated
| health_ordered = max( | ||
| [disk.get("health"), cpu.get("health")], | ||
| [disk.get("health", "healthy"), cpu.get("health", "healthy")], |
There was a problem hiding this comment.
Would it be ok to import it from the QuotaHealth enum?
diegodelemos
force-pushed
the
rs-296/simplify-du
branch
from
b08e425
to
5c4b6e5
Compare
* Shows disk usage format either in raw (bytes) or humand-friendly format (closes reanahub#296). * Remove unused marshmallow for openapi generation.
alintulu
force-pushed
the
rs-296/simplify-du
branch
from
5c4b6e5
to
6c00f30
Compare
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
=========================================
Coverage ? 50.80%
=========================================
Files ? 17
Lines ? 1374
Branches ? 0
=========================================
Hits ? 698
Misses ? 676
Partials ? 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
format (closes quotas: quota unit conversion server side #296).