-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow_run_manager: mount only db + workspace #229
Conversation
@@ -467,3 +457,19 @@ def _create_job_controller_startup_cmd(self, user=None): | |||
return [full_cmd] | |||
else: | |||
return base_cmd.split() | |||
|
|||
def _get_volume_mounts(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would reana_commons.k8s.volumes:get_shared_volume be of help here? if not we could adapt it, note that there we are changing depending of the deployment type CEPH or local Minikube, something we miss here.
SHARED_VOLUME_PATH + '/' + worksapce, | ||
'subPath': worksapce | ||
} | ||
db_mount = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need the DB mount? can you recheck it? :)
8677ce5
to
70fb545
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, it just needs rebase :)
P.S. I had a comment while reviewing, but it doesn't belong to this PR since you didn't introduce it, so I've created an issue #231.
d12385b
to
45b2422
Compare
* Closes reanahub#225 Signed-off-by: Rokas Maciulaitis <rokas.maciulaitis@cern.ch>
45b2422
to
44b6d5e
Compare
Signed-off-by: Rokas Maciulaitis rokas.maciulaitis@cern.ch