workflow_run_manager: mount only db + workspace #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -467,3 +457,19 @@ def _create_job_controller_startup_cmd(self, user=None): | |||
| return [full_cmd] | |||
| else: | |||
| return base_cmd.split() | |||
|
|
|||
| def _get_volume_mounts(self): | |||
There was a problem hiding this comment.
Would reana_commons.k8s.volumes:get_shared_volume be of help here? if not we could adapt it, note that there we are changing depending of the deployment type CEPH or local Minikube, something we miss here.
| SHARED_VOLUME_PATH + '/' + worksapce, | ||
| 'subPath': worksapce | ||
| } | ||
| db_mount = { |
There was a problem hiding this comment.
Do we really need the DB mount? can you recheck it? :)
roksys
force-pushed
the
mount-only-db-workspace
branch
3 times, most recently
from
8677ce5
to
70fb545
Compare
3 tasks
diegodelemos
approved these changes
Jul 19, 2019
There was a problem hiding this comment.
Looks good, it just needs rebase :)
P.S. I had a comment while reviewing, but it doesn't belong to this PR since you didn't introduce it, so I've created an issue #231.
roksys
force-pushed
the
mount-only-db-workspace
branch
2 times, most recently
from
d12385b
to
45b2422
Compare
* Closes reanahub#225 Signed-off-by: Rokas Maciulaitis <rokas.maciulaitis@cern.ch>
tiborsimko
approved these changes
Jul 23, 2019
tiborsimko
force-pushed
the
mount-only-db-workspace
branch
from
45b2422
to
44b6d5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rokas Maciulaitis rokas.maciulaitis@cern.ch