Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consumer: removes unused task #255

Merged
merged 1 commit into from
Oct 9, 2019
Merged

consumer: removes unused task #255

merged 1 commit into from
Oct 9, 2019

Conversation

roksys
Copy link
Contributor

@roksys roksys commented Oct 9, 2019

@roksys roksys added this to In progress in Condor-Slurm-Demo via automation Oct 9, 2019
@roksys roksys moved this from In progress to Review in progress in Condor-Slurm-Demo Oct 9, 2019
diegodelemos
diegodelemos reviewed Oct 9, 2019
View reviewed changes
reana_workflow_controller/consumer.py Outdated
@@ -76,8 +73,6 @@ def _update_workflow_status(workflow_uuid, status, logs):
_update_commit_status(workflow, status)
alive_statuses = \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you delete this as well? It is not used either.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to rebase :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

Condor-Slurm-Demo automation moved this from Review in progress to Reviewer approved Oct 9, 2019
@diegodelemos diegodelemos merged commit 441e28b into reanahub:master Oct 9, 2019
Condor-Slurm-Demo automation moved this from Reviewer approved to Done Oct 9, 2019
@diegodelemos diegodelemos mentioned this pull request Oct 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegodelemos diegodelemos diegodelemos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Condor-Slurm-Demo
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consumer: remove unused task
2 participants
@roksys @diegodelemos