api: stream file uploads using request.stream #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegodelemos
force-pushed
the
reana-client-302-big-file-upload-bug
branch
from
7123fa4
to
40ec209
Compare
diegodelemos
changed the title
* After the findings in https://github.com/diegodelemos/client-server-flask-big-file-uploads it is clear we have to move from multipart uploads to stream uploads using `request.stream` directly (closes reanahub/reana-client#302).
diegodelemos
force-pushed
the
reana-client-302-big-file-upload-bug
branch
from
40ec209
to
f1fc530
Compare
tiborsimko
reviewed
Oct 16, 2019
reana_workflow_controller/rest.py
Outdated
| @@ -456,7 +466,7 @@ def upload_file(workflow_id_or_name): | |||
| 'Please set your REANA_WORKON environment' | |||
| 'variable appropriately.'. | |||
| format(workflow_id_or_name)}), 404 | |||
| except (KeyError, ValueError) as e: | |||
| except (KeyError, ) as e: | |||
There was a problem hiding this comment.
can also remove tuple if we keep one exception only
|
Updated. |
tiborsimko
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/diegodelemos/client-server-flask-big-file-uploads
it is clear we have to move from multipart uploads to stream uploads
using
request.streamdirectly (closes cli: error uploading a large file reana-client#302).