Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: full analysis repository shown in the workspace when running from GitLab #240

Closed
diegodelemos opened this issue Jan 13, 2020 · 0 comments · Fixed by reanahub/reana-client#351

Comments

@diegodelemos
Copy link
Member

The GitLab integration pulls the whole analysis git repository to be able to run the analysis, this is similar to what Travis does, see this example.

In the REANA case, we clone to the workflow workspace and the reana ls looks like this:

$ rc ls -w "REANA example - ROOT6 and RooFit"                                                                                                                    
NAME                                                                   SIZE     LAST-MODIFIED                                                                                                       
reana.yaml                                                             628      2020-01-13T09:36:42                                                                                                 
reana-slurmcern.yaml                                                   698      2020-01-13T09:36:42                                                                                                 
README.rst                                                             7541     2020-01-13T09:36:42                                                                                                 
reana-yadage.yaml                                                      215      2020-01-13T09:36:42                                                                                                 
reana-cwl.yaml                                                         127      2020-01-13T09:36:42                                                                                                 
LICENSE                                                                1068     2020-01-13T09:36:42                                                                                                 
gendata.log                                                            2141     2020-01-13T09:37:23                                                                                                 
.gitignore                                                             9        2020-01-13T09:36:42                                                                                                 
reana-htcondorcern.yaml                                                704      2020-01-13T09:36:42                                                                                                 
code/gendata.C                                                         1937     2020-01-13T09:36:42                                                                                                 
code/fitdata.C                                                         1648     2020-01-13T09:36:42                                                                                                 
.git/HEAD                                                              23       2020-01-13T09:36:42                                                                                                 
.git/description                                                       73       2020-01-13T09:36:41                                                                                                 
.git/index                                                             1552     2020-01-13T09:36:42                                                                                                 
.git/packed-refs                                                       114      2020-01-13T09:36:41                                                                                                 
.git/config                                                            356      2020-01-13T09:36:42                                                                                                 
.git/ORIG_HEAD                                                         41       2020-01-13T09:36:42                                                                                                 
results/data.root                                                      296735   2020-01-13T09:37:23                                                                                                 
docs/plot.png                                                          16273    2020-01-13T09:36:42                                                                                                 
.git/hooks/pre-commit.sample                                           1638     2020-01-13T09:36:41                                                                                                 
.git/hooks/fsmonitor-watchman.sample                                   3327     2020-01-13T09:36:41                                                                                                 
.git/hooks/commit-msg.sample                                           896      2020-01-13T09:36:41
.git/hooks/pre-rebase.sample                                           4898     2020-01-13T09:36:41
.git/hooks/pre-receive.sample                                          544      2020-01-13T09:36:41
.git/hooks/prepare-commit-msg.sample                                   1492     2020-01-13T09:36:41
.git/hooks/update.sample                                               3610     2020-01-13T09:36:41
.git/hooks/pre-push.sample                                             1348     2020-01-13T09:36:41
.git/hooks/pre-applypatch.sample                                       424      2020-01-13T09:36:41
.git/hooks/post-update.sample                                          189      2020-01-13T09:36:41
.git/hooks/applypatch-msg.sample                                       478      2020-01-13T09:36:41
.git/logs/HEAD                                                         512      2020-01-13T09:36:42
.git/info/exclude                                                      240      2020-01-13T09:36:41
workflow/cwl/fitdata.cwl                                               624      2020-01-13T09:36:42
workflow/cwl/input.yml                                                 116      2020-01-13T09:36:42
workflow/cwl/gendata.cwl                                               619      2020-01-13T09:36:42
workflow/cwl/workflow.cwl                                              985      2020-01-13T09:36:42
workflow/yadage/workflow.yaml                                          1869     2020-01-13T09:36:42
.git/objects/pack/pack-04594cb6c1864245d77d49d9684ba79f80617592.idx    5832     2020-01-13T09:36:41
.git/objects/pack/pack-04594cb6c1864245d77d49d9684ba79f80617592.pack   68007    2020-01-13T09:36:41
.git/refs/heads/master                                                 41       2020-01-13T09:36:42
.git/logs/refs/heads/master                                            299      2020-01-13T09:36:42
.git/refs/remotes/origin/HEAD                                          32       2020-01-13T09:36:42
.git/logs/refs/remotes/origin/HEAD                                     299      2020-01-13T09:36:42

We should focus only on what's important for the analysis, and the private .git folder is not, removing hidden folders (./ ) would help already. Besides, we should think of whether we should only clone/display the necessary files which are listed in reana.yaml:

...
inputs:
  files:
    - code/gendata.C
    - code/fitdata.C
...
@diegodelemos diegodelemos added this to Ready for work in Awesome-Workshop-Basics Jan 13, 2020
@mvidalgarcia mvidalgarcia moved this from Ready for work to In work in Awesome-Workshop-Basics Jan 14, 2020
@mvidalgarcia mvidalgarcia self-assigned this Jan 14, 2020
mvidalgarcia added a commit to mvidalgarcia/reana-client that referenced this issue Jan 14, 2020
mvidalgarcia added a commit to mvidalgarcia/reana-client that referenced this issue Jan 14, 2020
@mvidalgarcia mvidalgarcia moved this from In work to In review in Awesome-Workshop-Basics Jan 14, 2020
Awesome-Workshop-Basics automation moved this from In review to Done Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants