cli: hide .git related files #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidalgarcia
force-pushed
the
r/240-gitlab-workspace
branch
from
4ce971a
to
aeb96e1
Compare
roksys
reviewed
Jan 15, 2020
| @@ -31,6 +31,9 @@ | |||
| from reana_commons.utils import click_table_printer | |||
|
|
|||
|
|
|||
| FILES_BLACKLIST = ('.git/', '/.git/') | |||
There was a problem hiding this comment.
Is there a need for '/.git/' ?
There was a problem hiding this comment.
Yes, this is how reana-client du prints the information. This is what reana-client obtains from the server:
...
{'name': '/.git/info/exclude', 'size': '4.0K'}
{'name': '/.git/info', 'size': '4.0K'}
{'name': '/.git/branches', 'size': '0'}
...
roksys
approved these changes
Jan 15, 2020
mvidalgarcia
force-pushed
the
r/240-gitlab-workspace
branch
from
aeb96e1
to
f3623d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes reanahub/reana#240