Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5 component refactor: File uploader #146

Open
11 tasks
HollyJoyPhillips opened this issue Jul 30, 2024 · 1 comment
Open
11 tasks

v5 component refactor: File uploader #146

HollyJoyPhillips opened this issue Jul 30, 2024 · 1 comment
Labels
feature The issue relates to a new feature v5 Issues for v5 release

Comments

@HollyJoyPhillips
Copy link

HollyJoyPhillips commented Jul 30, 2024

Abstract

As part of the v5 Elements release, each component will be reviewed and refactored to ensure best practice and design system alignment

Specification

Developer Checklist

  • Styles alignment between Design System and Elements
  • Check design tokens in Figma and implement CSS variable tokens if available for relevant component
  • Align with accessibility standards / spec as per above
  • If relevant, break down component into Styles Only and React component structures
  • Ensure all variants of components are documented as appropriate
  • Ensure unit test coverage is adequate for component
  • Update documentation in MDX file as per guidelines
  • Changelog updated to reflect a single beta version per component ideally

Release Checklist

  • Approved PR merged to main
  • Design & product review and feedback addressed by developer
  • Beta release by product / engineering lead to next beta version

Additional Context or Information

@HollyJoyPhillips HollyJoyPhillips added feature The issue relates to a new feature v5 Issues for v5 release labels Jul 30, 2024
@kurtdoherty
Copy link
Contributor

suggestion: In my opinion, this work should be deferred for later. File uploaders are not simple to build and, while we could focus on just the presentational concerns, I think there's still a decent amount of thinking required to ensure we build those presentational atoms in a way that allows as many of our products to leverage them correctly despite a myriad of different file upload "tech stacks" and user experiences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature The issue relates to a new feature v5 Issues for v5 release
Projects
Status: To Review
Development

No branches or pull requests

2 participants