-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to focus on toggle options #87
Comments
@jmsfwk This is now fixed and release in v4.2.0 |
@willmcvay I've tested this on https://elements.reapit.cloud/?path=/docs/formlayout--docs and I don't think it matches the keyboard interactions that you expect from a checkbox or radio button group. We also use the Elements CSS without React, which I understand you might not support. CheckboxOn a checkbox toggle I expect that Space will change the state of the toggle (as it does on the plain checkbox). https://www.w3.org/WAI/ARIA/apg/patterns/switch/ RadioOn a radio group I expect that I would tab into the group and then use Left / Right or Up / Down to move through the options, not Tab. |
@jmsfwk I'll re-open and take a look. Trying to avoid breaking changes at this major version so may be one we have to move into our v5 release - will see what can be done. |
The core bug is fixed in the sense the react focus issues is addressed and the toggle is functional. Agree though, this behaviour is preferable and suggest we do this in v5 - I had a look and the desired functionality is hard to achieve without breaking the markup and therefore a breaking change. Will add a v5 flag. |
Describe the bug
It's not possible to use the keyboard to focus on or change a selected toggle checkbox state or toggle radio option.
To Reproduce
Steps to reproduce the behaviour eg:
Expected behaviour
Screenshots
Device (please complete the following information for web issues):
Additional context
I think the inability to focus on the toggle is caused by the
visibility: hidden
. Bootstrap use the following declaration, which does solve the issue.The text was updated successfully, but these errors were encountered: