Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass createClass #40

Closed
chenglou opened this issue Feb 10, 2017 · 6 comments
Closed

Bypass createClass #40

chenglou opened this issue Feb 10, 2017 · 6 comments

Comments

@chenglou
Copy link
Contributor

createClass will be moved out of React core. We don't currently compile to es6 classes (the spec isn't even finalized), so we can take this occasion to also drop our internal usage of createClass, and wire things up into React ourselves. Page initialization cost should go down a bit.

@slonoed
Copy link

slonoed commented Apr 9, 2017

Hi! React remove createClass in version 16. Do you have plans on this ticket? There is create-react-class that provide migration. Maybe it can be used.
I want to help with this, but I don't know your plans.

@chenglou
Copy link
Contributor Author

chenglou commented Apr 10, 2017

We'll simply wire things up under the hood by looking at how es6 classes work. cc @IwanKaramazow. It might only be a few lines change.

@aweary
Copy link

aweary commented May 16, 2017

Would it be worth using create-react-class for now until ES6 classes are wired up? Currently, new projects using reason-react will get the deprecation warning introduced in 15.5, without a way to get rid of it.

@xtuc
Copy link

xtuc commented May 23, 2017

I'm new to reasonml 👋 and would like to get this done.

What should we do with the additional dependency (create-react-class)?

  • It could be a peerDep as with React and React-dom (package.json#L22-L23) but all React app won't have create-react-class as dep.

  • Or should I add it to devDeps?

@rt2zz
Copy link

rt2zz commented May 25, 2017

imo it should be a regular dependency

@chenglou
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants