Add schema cache implementation #1008

sforward · 2023-03-21T13:13:55Z

Summary

Currently, on every single request the schema is built by instantiating all types, queries, mutations, etc, and calling all args, fields and type methods. This takes some time, especially when you have lots of queries and mutations. When investigating this issue, I came across a possible solution in de docs of webonyx/graphql-php. This works by caching the intermediate parsed representation of the schema to the filesystem. After loading from cache only the necessary classes will be resolved.

The schema cache could be enabled via the config. By default it is disabled on local environment:

    'schema_cache' => [
        // Enable/disable the schema cache
        'enable' => env('GRAPHQL_SCHEMA_CACHE', 'local' !== env('APP_ENV')),

        'cache_driver' => env('GRAPHQL_SCHEMA_CACHE_DRIVER', config('cache.default')),

        'cache_prefix' => env('GRAPHQL_SCHEMA_CACHE_PREFIX', 'graphql.schema_cache'),
    ],

If the schema cache is enabled, it could be disabled per schema via the config:

    'schemas' => [
        'default' => [
            'query' => [
                // ExampleQuery::class,
            ],

            // etc ...

            // Disable schema cache for this schema
            'disable_cache' => true,
        ],
    ],

The implementation comes with some breaking changes, so hopefully it's in time for v9. When this PR is approved, I will update the readme and the changelog.

Type of change:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

Existing tests have been adapted and/or new tests have been added
Add a CHANGELOG.md entry
Update the README.md
Code style has been fixed via composer fix-style

mfn

Wow, super interesting 👀

I think for the final version the cache should be configurable, similar to what we did we apq caching (driver, prefix [maybe?], ttl).

It will take be some time, so no ETA atm

mfn · 2023-03-21T21:10:15Z

src/SchemaCache.php

+    public function __construct(Application $app, Cache $cache, Config $config)
+    {
+        $this->app = $app;
+        $this->cache = $cache;


This property isn't used, I guess the current file_(get|put)_contents and etc. will be changed to use it?

sforward · 2023-03-22T07:09:00Z

Thanks for the feedback! Fair point about the configurability of this cache. I will look into it soon. Besides, I experienced a problem with custom scalars that needs to be fixed too.

mfn · 2023-03-22T08:44:32Z

Ok, thanks for your work on this! For now, I'll put the PR in draft mode!

sforward · 2023-03-25T09:28:48Z

The issues with the scalars and types have been resolved now, by the new TypeConfigDecorator class. The pagination types are not defined via the config, so to resolve them consistently I have added an abstract parent. Custom or new pagination types need to extend this AbstractPaginationType class, to handle them with schema cache.

I have also made the schema cache configurable (I have updated the example in my original comment). By default the schema cache is disabled on local environment. It only needs to be refreshed if the schema config changes.

websitevirtuoso · 2023-04-07T05:58:02Z

Looks great. do we have any news about this feature?

mfn · 2023-04-07T06:42:40Z

I'm waiting for enough free time to focus on it for the review: I think it's a super interesting feature!

websitevirtuoso · 2023-04-07T18:56:10Z

Yes Really good feature especially when schema and gql parsing consume time. my gql queries take by 1 sec. but sql queries fine by 30-50ms

mfn · 2023-04-08T16:48:18Z

I wanted to take a look a bit around in the implementation, but due to recent changes in orchestra/testbench, unrelated to the PR, not all tests worked; therefore I merged master into it.

mfn

I can't get it working in a private project because the first error I get is that it can't resolve a scalar from the cached schema.

I unfortunately can't share the code and right now I don't have time to build a minimal case, thus I try to share as much details as possible:

The scalar is registered like any other type in the config/graphql.php, in the per-schema 'types', it's registered like any regular type with App\GraphQL\Scalars\Date::class
it's not specific to that scalar; I've multiple scalars defined and when I started to comment out this one, the next one threw up. It's just too many scalars and usages so I couldn't quickly disable all of them to see if that's everything or not
the schema works in the first request, where it's not yet fetched from the cache; but fails on the second

Stacktrace (with some obfuscation)

[2023-04-08T18:29:25.583680+00:00] local.ERROR: Undefined index: Date {"userId":XXXX,"exception":"[object] (ErrorException(code: 0): Undefined index: Date at /project/vendor/rebing/graphql-laravel/src/Support/SchemaCache/TypeConfigDecorator.php:163)
[stacktrace]
#0 /project/vendor/rebing/graphql-laravel/src/Support/SchemaCache/TypeConfigDecorator.php(163): Illuminate\\Foundation\\Bootstrap\\HandleExceptions->handleError(8, 'Undefined index...', '/project/ve...', 163, Array)
#1 /project/vendor/rebing/graphql-laravel/src/Support/SchemaCache/TypeConfigDecorator.php(40): Rebing\\GraphQL\\Support\\SchemaCache\\TypeConfigDecorator->decorateScalar(Array)
#2 /project/vendor/webonyx/graphql-php/src/Utils/ASTDefinitionBuilder.php(265): Rebing\\GraphQL\\Support\\SchemaCache\\TypeConfigDecorator->__invoke(Array, Object(GraphQL\\Language\\AST\\ScalarTypeDefinitionNode), Array)
#3 /project/vendor/webonyx/graphql-php/src/Utils/ASTDefinitionBuilder.php(215): GraphQL\\Utils\\ASTDefinitionBuilder->internalBuildType('Date', Object(GraphQL\\Language\\AST\\NamedTypeNode))
#4 /project/vendor/webonyx/graphql-php/src/Utils/ASTDefinitionBuilder.php(196): GraphQL\\Utils\\ASTDefinitionBuilder->buildType(Object(GraphQL\\Language\\AST\\NamedTypeNode))
#5 /project/vendor/webonyx/graphql-php/src/Utils/ASTDefinitionBuilder.php(193): GraphQL\\Utils\\ASTDefinitionBuilder->buildWrappedType(Object(GraphQL\\Language\\AST\\NamedTypeNode))
#6 /project/vendor/webonyx/graphql-php/src/Utils/ASTDefinitionBuilder.php(140): GraphQL\\Utils\\ASTDefinitionBuilder->buildWrappedType(Object(GraphQL\\Language\\AST\\NonNullTypeNode))
#7 /project/vendor/webonyx/graphql-php/src/Utils/ASTDefinitionBuilder.php(385): GraphQL\\Utils\\ASTDefinitionBuilder->makeInputValues(Object(GraphQL\\Language\\AST\\NodeList))
#8 /project/vendor/webonyx/graphql-php/src/Utils/ASTDefinitionBuilder.php(361): GraphQL\\Utils\\ASTDefinitionBuilder->buildField(Object(GraphQL\\Language\\AST\\FieldDefinitionNode))
#9 /project/vendor/webonyx/graphql-php/src/Utils/ASTDefinitionBuilder.php(342): GraphQL\\Utils\\ASTDefinitionBuilder->makeFieldDefMap(Array)
#10 /project/vendor/rebing/graphql-laravel/src/Support/SchemaCache/TypeConfigDecorator.php(68): GraphQL\\Utils\\ASTDefinitionBuilder->GraphQL\\Utils\\{closure}()
#11 /project/vendor/webonyx/graphql-php/src/Type/Definition/FieldDefinition.php(119): Rebing\\GraphQL\\Support\\SchemaCache\\TypeConfigDecorator->Rebing\\GraphQL\\Support\\SchemaCache\\{closure}()
#12 /project/vendor/webonyx/graphql-php/src/Type/Definition/HasFieldsTypeImplementation.php(28): GraphQL\\Type\\Definition\\FieldDefinition::defineFieldMap(Object(GraphQL\\Type\\Definition\\ObjectType), Object(Closure))
#13 /project/vendor/webonyx/graphql-php/src/Type/Definition/HasFieldsTypeImplementation.php(69): GraphQL\\Type\\Definition\\ObjectType->initializeFields()
#14 /project/vendor/webonyx/graphql-php/src/Validator/Rules/OverlappingFieldsCanBeMerged.php(253): GraphQL\\Type\\Definition\\ObjectType->hasField('me')
#15 /project/vendor/webonyx/graphql-php/src/Validator/Rules/OverlappingFieldsCanBeMerged.php(162): GraphQL\\Validator\\Rules\\OverlappingFieldsCanBeMerged->internalCollectFieldsAndFragmentNames(Object(GraphQL\\Validator\\QueryValidationContext), Object(GraphQL\\Type\\Definition\\ObjectType), Object(GraphQL\\Language\\AST\\SelectionSetNode), Array, Array)
#16 /project/vendor/webonyx/graphql-php/src/Validator/Rules/OverlappingFieldsCanBeMerged.php(92): GraphQL\\Validator\\Rules\\OverlappingFieldsCanBeMerged->getFieldsAndFragmentNames(Object(GraphQL\\Validator\\QueryValidationContext), Object(GraphQL\\Type\\Definition\\ObjectType), Object(GraphQL\\Language\\AST\\SelectionSetNode))
#17 /project/vendor/webonyx/graphql-php/src/Validator/Rules/OverlappingFieldsCanBeMerged.php(60): GraphQL\\Validator\\Rules\\OverlappingFieldsCanBeMerged->findConflictsWithinSelectionSet(Object(GraphQL\\Validator\\QueryValidationContext), Object(GraphQL\\Type\\Definition\\ObjectType), Object(GraphQL\\Language\\AST\\SelectionSetNode))
#18 /project/vendor/webonyx/graphql-php/src/Language/Visitor.php(388): GraphQL\\Validator\\Rules\\OverlappingFieldsCanBeMerged->GraphQL\\Validator\\Rules\\{closure}(Object(GraphQL\\Language\\AST\\SelectionSetNode), 'selectionSet', Object(GraphQL\\Language\\AST\\OperationDefinitionNode), Array, Array)
#19 /project/vendor/webonyx/graphql-php/src/Language/Visitor.php(451): GraphQL\\Language\\Visitor::GraphQL\\Language\\{closure}(Object(GraphQL\\Language\\AST\\SelectionSetNode), 'selectionSet', Object(GraphQL\\Language\\AST\\OperationDefinitionNode), Array, Array)
#20 /project/vendor/webonyx/graphql-php/src/Language/Visitor.php(261): GraphQL\\Language\\Visitor::GraphQL\\Language\\{closure}(Object(GraphQL\\Language\\AST\\SelectionSetNode), 'selectionSet', Object(GraphQL\\Language\\AST\\OperationDefinitionNode), Array, Array)
#21 /project/vendor/webonyx/graphql-php/src/Validator/DocumentValidator.php(122): GraphQL\\Language\\Visitor::visit(Object(GraphQL\\Language\\AST\\DocumentNode), Array)
#22 /project/vendor/webonyx/graphql-php/src/GraphQL.php(149): GraphQL\\Validator\\DocumentValidator::validate(Object(GraphQL\\Type\\Schema), Object(GraphQL\\Language\\AST\\DocumentNode), Array)
#23 /project/vendor/webonyx/graphql-php/src/GraphQL.php(92): GraphQL\\GraphQL::promiseToExecute(Object(GraphQL\\Executor\\Promise\\Adapter\\SyncPromiseAdapter), Object(GraphQL\\Type\\Schema), Object(GraphQL\\Language\\AST\\DocumentNode), NULL, Object(App\\GraphQL\\Context), NULL, NULL, Array, NULL)
#24 /project/vendor/rebing/graphql-laravel/src/Support/ExecutionMiddleware/GraphqlExecutionMiddleware.php(32): GraphQL\\GraphQL::executeQuery(Object(GraphQL\\Type\\Schema), Object(GraphQL\\Language\\AST\\DocumentNode), NULL, Object(App\\GraphQL\\Context), NULL, NULL, Array)
#25 /project/vendor/rebing/graphql-laravel/src/Support/ExecutionMiddleware/AbstractExecutionMiddleware.php(34): Rebing\\GraphQL\\Support\\ExecutionMiddleware\\GraphqlExecutionMiddleware->handle('default', Object(GraphQL\\Type\\Schema), Object(Rebing\\GraphQL\\Support\\OperationParams), NULL, Object(App\\GraphQL\\Context), Object(Closure))
#26 /project/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Rebing\\GraphQL\\Support\\ExecutionMiddleware\\AbstractExecutionMiddleware->resolve(Array, Object(Closure))
#27 /project/vendor/rebing/graphql-laravel/src/Support/ExecutionMiddleware/AbstractExecutionMiddleware.php(33): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Array)
#28 /project/app/GraphQL/Middleware/Execution/ContextValueMiddleppware.php(31): Rebing\\GraphQL\\Support\\ExecutionMiddleware\\AbstractExecutionMiddleware->Rebing\\GraphQL\\Support\\ExecutionMiddleware\\{closure}('default', Object(GraphQL\\Type\\Schema), Object(Rebing\\GraphQL\\Support\\OperationParams), NULL, Object(App\\GraphQL\\Context))
#29 /project/vendor/rebing/graphql-laravel/src/Support/ExecutionMiddleware/AbstractExecutionMiddleware.php(34): App\\GraphQL\\Middleware\\Execution\\ContextValueMiddleware->handle('default', Object(GraphQL\\Type\\Schema), Object(Rebing\\GraphQL\\Support\\OperationParams), NULL, Object(App\\GraphQL\\Context), Object(Closure))
#30 /project/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Rebing\\GraphQL\\Support\\ExecutionMiddleware\\AbstractExecutionMiddleware->resolve(Array, Object(Closure))
#31 /project/vendor/rebing/graphql-laravel/src/Support/ExecutionMiddleware/AbstractExecutionMiddleware.php(33): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Array)
#32 /project/vendor/rebing/graphql-laravel/src/Support/ExecutionMiddleware/AutomaticPersistedQueriesMiddleware.php(42): Rebing\\GraphQL\\Support\\ExecutionMiddleware\\AbstractExecutionMiddleware->Rebing\\GraphQL\\Support\\ExecutionMiddleware\\{closure}('default', Object(GraphQL\\Type\\Schema), Object(Rebing\\GraphQL\\Support\\OperationParams), NULL, NULL)
#33 /project/vendor/rebing/graphql-laravel/src/Support/ExecutionMiddleware/AbstractExecutionMiddleware.php(34): Rebing\\GraphQL\\Support\\ExecutionMiddleware\\AutomaticPersistedQueriesMiddleware->handle('default', Object(GraphQL\\Type\\Schema), Object(Rebing\\GraphQL\\Support\\OperationParams), NULL, NULL, Object(Closure))
#34 /project/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Rebing\\GraphQL\\Support\\ExecutionMiddleware\\AbstractExecutionMiddleware->resolve(Array, Object(Closure))
#35 /project/vendor/rebing/graphql-laravel/src/Support/ExecutionMiddleware/AbstractExecutionMiddleware.php(33): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Array)
#36 /project/vendor/rebing/graphql-laravel/src/Support/ExecutionMiddleware/ValidateOperationParamsMiddleware.php(39): Rebing\\GraphQL\\Support\\ExecutionMiddleware\\AbstractExecutionMiddleware->Rebing\\GraphQL\\Support\\ExecutionMiddleware\\{closure}('default', Object(GraphQL\\Type\\Schema), Object(Rebing\\GraphQL\\Support\\OperationParams), NULL, NULL)
#37 /project/vendor/rebing/graphql-laravel/src/Support/ExecutionMiddleware/AbstractExecutionMiddleware.php(34): Rebing\\GraphQL\\Support\\ExecutionMiddleware\\ValidateOperationParamsMiddleware->handle('default', Object(GraphQL\\Type\\Schema), Object(Rebing\\GraphQL\\Support\\OperationParams), NULL, NULL, Object(Closure))
#38 /project/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Rebing\\GraphQL\\Support\\ExecutionMiddleware\\AbstractExecutionMiddleware->resolve(Array, Object(Closure))
#39 /project/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Array)
#40 /project/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(115): Illuminate\\Pipeline\\Pipeline->then(Object(Closure))
#41 /project/vendor/rebing/graphql-laravel/src/GraphQL.php(184): Illuminate\\Pipeline\\Pipeline->thenReturn()
#42 /project/vendor/rebing/graphql-laravel/src/GraphQL.php(167): Rebing\\GraphQL\\GraphQL->executeViaMiddleware(Array, 'default', Object(GraphQL\\Type\\Schema), Object(Rebing\\GraphQL\\Support\\OperationParams), NULL, NULL)
#43 /project/vendor/rebing/graphql-laravel/src/GraphQL.php(153): Rebing\\GraphQL\\GraphQL->executeAndReturnResult('default', Object(GraphQL\\Type\\Schema), Object(Rebing\\GraphQL\\Support\\OperationParams), NULL, NULL)
#44 /project/vendor/rebing/graphql-laravel/src/GraphQLController.php(41): Rebing\\GraphQL\\GraphQL->execute('default', Object(Rebing\\GraphQL\\Support\\OperationParams))
#45 /project/vendor/rebing/graphql-laravel/src/Helpers.php(25): Rebing\\GraphQL\\GraphQLController->Rebing\\GraphQL\\{closure}(Object(GraphQL\\Server\\OperationParams))
#46 /project/vendor/rebing/graphql-laravel/src/GraphQLController.php(38): Rebing\\GraphQL\\Helpers::applyEach(Object(Closure), Object(GraphQL\\Server\\OperationParams))
…
[cut off, outside of graphql here]

Spefifically, it's this code part throwing:

    protected function decorateScalar(array $config): array
    {
        $className = $this->classMapping['types'][$config['astNode']->name->value];

It looks up Date but the mappings are expressed as App\\GraphQL\Scalars\Date.

HTH

src/Support/SchemaCache/TypeConfigDecorator.php

sforward · 2023-04-14T12:33:29Z

I've improved the mapping from name to type class, when not provided via the config. This mapping is also cached now.

I needed to access the name of the queries/types, so I introduced a getName method. The name was already accessible via the magic getter, but this also calls several other methods, causing other problems.

mfn · 2023-04-14T16:08:34Z

Thx, I hope this I'll find sooner time to test it!

Was something wrong with my configuration or what would been a config which worked? 🤔

mfn · 2023-04-14T19:52:46Z

src/Support/SchemaCache/SchemaCache.php

+            'types' => $this->config->get('graphql.types', []),
+        ];
+
+        foreach ($schemaConfig as $group => $types) {


This method neglects to consider we don't just have GraphQL types in the config. There are keys (in this case: $group) which are middleware, method or execution_middleware.

I think this code needs to only act on the specifics (query, mutation and types).

Btw, this this also work when global types are defined?

FTR, in my case I now can't even load anything once schema caching is enabled:

[2023-04-14T19:45:30.293877+00:00] local.ERROR: Target class [name-of-middleware] does not exist. {"exception":"[object] (Illuminate\\Contracts\\Container\\BindingResolutionException(code: 0): Target class [name-of-middleware] does not exist. at /project/vendor/laravel/framework/src/Illuminate/Container/Container.php:879) [stacktrace] #0 /project/vendor/laravel/framework/src/Illuminate/Container/Container.php(758): Illuminate\\Container\\Container->build('name-of-middleware') #1 /project/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(851): Illuminate\\Container\\Container->resolve('name-of-middleware', Array, true) #2 /project/vendor/laravel/framework/src/Illuminate/Container/Container.php(694): Illuminate\\Foundation\\Application->resolve('name-of-middleware', Array) #3 /project/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(836): Illuminate\\Container\\Container->make('name-of-middleware', Array) #4 /project/app/Services/Vendor/Illuminate/Foundation/Application.php(49): Illuminate\\Foundation\\Application->make('name-of-middleware', Array) #5 /project/vendor/laravel/framework/src/Illuminate/Foundation/helpers.php(119): App\\Services\\Vendor\\Illuminate\\Foundation\\Application->make('name-of-middleware', Array) #6 /project/vendor/rebing/graphql-laravel/src/Support/SchemaCache/SchemaCache.php(121): app('name-of-middleware') …

(Note: there's a custom Application at play, which however does not play a role for this issue)

I have pushed a fix and test for this config issue! Global types were already supported, see the Upload type in the SchemaCacheTest class.

mfn · 2023-05-12T12:37:14Z

@sforward are you still interested in wrapping up?

I hope to push the new major version out soon-ish.

sforward · 2023-05-30T07:20:01Z

Absolutely, I missed your last feedback but will look into soon!

mfn · 2023-06-04T19:09:11Z

The first impression I now got is that everything is working.

I then did some very primitive benchmarking and did not see any improvements. Before proceeding I want to find out how to best properly measure this.

My test is really simply:

schema has 200+ types, 100+ queries, 100+ mutations
I triggered a real GraphQL call to my application (requires proper auth, a session, etc.), something like
```
query itsame { me { id } }
```
so, very simple
saved it as a curl call (from the browsers network tab) and made sure it's working
user https://github.com/sharkdp/hyperfine to run this curl command in a loop (I naively believe the shell / process forking overhead is negligible)
I performed the test under OSX 13.3.1 on a MPB (older model: 2,4 GHz 8-Core Intel Core i9)
command performed:
time hyperfine --warmup 10 --runs <n> --export-markdown <file>.md './curl_command.sh'

Cache off, 100 iterations

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`./curl_command.sh`	364.7 ± 60.1	280.0	541.3	1.00

Cache off, 1000 iterations

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`./curl_command.sh`	372.6 ± 92.3	282.9	604.3	1.00

Cache on, 100 iterations

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`./curl_command.sh`	381.1 ± 97.4	298.6	551.1	1.00

Cache on, 1000 iterations

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`./curl_command.sh`	395.6 ± 71.6	302.1	792.4	1.00

It actually seems slower a bit. I made sure the cache is working, checked the cache key and it's a very big json blob so this part seems to work.

I then tried using a different approach, copied the GraphQL request from the browser network tab as fetch-command and wrote a simple loop to run in the browser JS console and measure the duration (each time I changed the config, I made a run with 10 iterations for the warmup):

(async() => {
  console.time();
  for (i = 0; i < 1000; i++) {
    var res = await fetch('https://host/api/graphql', {
      // …
      'body': '{"query":"query itsame {\\n  me {\\n    id\\n  }\\n}","operationName":"itsame"}',
      // …
    });
    console.log(await res.text());
  }
  console.timeEnd();
})();

cache off: 80737ms = 80s
cache on: 133672ms = 133s

🤷🏼

I also have some failing tests in my private project to look into, but I first want to measure the improvement. A couple of years ago we had #390 where we did some benchmarks but there was no code-optimization-change outcome AFAIR.

How did you benchmark it?

sforward · 2023-07-01T07:50:15Z

I have not enough time to keep this going currently. I will close this PR for now, hopefully I find some time later this year.

mfn · 2023-07-01T09:09:01Z

😭

sure thing! Let's all enjoy summer 🏖️

mfn reviewed Mar 21, 2023

View reviewed changes

mfn assigned sforward Mar 22, 2023

mfn marked this pull request as draft March 22, 2023 08:44

sforward marked this pull request as ready for review March 25, 2023 09:28

sforward requested a review from mfn March 25, 2023 09:29

mfn reviewed Apr 8, 2023

View reviewed changes

src/Support/SchemaCache/TypeConfigDecorator.php Outdated Show resolved Hide resolved

sforward force-pushed the feat/ast-cache branch from 6f8feb0 to 8ea785d Compare April 14, 2023 06:22

mfn requested changes Apr 14, 2023

View reviewed changes

sforward added 9 commits June 3, 2023 14:00

feat: add schema caching

5d8a393

fix: support schema cache with class-based schema config

e44637b

refactor!: move duplicate code of Pagination types to abstract parent

4485e22

feat: improved type config decorator

338f0b2

feat: improve schema cache config

13d5489

chore: disable schema cache during tests

52678fe

fix: support SelectFields with schema cache

f21e9dc

feat: allow access to type/operation name without calling extra methods

51c0a25

fix: cache class mapping

9d64b3a

sforward force-pushed the feat/ast-cache branch from 8ea785d to 9d64b3a Compare June 3, 2023 12:14

chore: update phpstan baseline with php 8.2

5f12b0b

fix: correctly handle other config keys

d107c97

mfn mentioned this pull request Jun 5, 2023

pagination: enforce nonNull on the inner type as well as on the list #1033

Merged

9 tasks

sforward closed this Jul 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add schema cache implementation #1008

Add schema cache implementation #1008

sforward commented Mar 21, 2023 •

edited

Loading

mfn left a comment

mfn Mar 21, 2023

sforward commented Mar 22, 2023

mfn commented Mar 22, 2023

sforward commented Mar 25, 2023

websitevirtuoso commented Apr 7, 2023

mfn commented Apr 7, 2023

websitevirtuoso commented Apr 7, 2023

mfn commented Apr 8, 2023

mfn left a comment

sforward commented Apr 14, 2023

mfn commented Apr 14, 2023

mfn Apr 14, 2023

sforward Jun 3, 2023

mfn commented May 12, 2023

sforward commented May 30, 2023

mfn commented Jun 4, 2023

sforward commented Jul 1, 2023

mfn commented Jul 1, 2023

Add schema cache implementation #1008

Add schema cache implementation #1008

Conversation

sforward commented Mar 21, 2023 • edited Loading

Summary

mfn left a comment

Choose a reason for hiding this comment

mfn Mar 21, 2023

Choose a reason for hiding this comment

sforward commented Mar 22, 2023

mfn commented Mar 22, 2023

sforward commented Mar 25, 2023

websitevirtuoso commented Apr 7, 2023

mfn commented Apr 7, 2023

websitevirtuoso commented Apr 7, 2023

mfn commented Apr 8, 2023

mfn left a comment

Choose a reason for hiding this comment

sforward commented Apr 14, 2023

mfn commented Apr 14, 2023

mfn Apr 14, 2023

Choose a reason for hiding this comment

sforward Jun 3, 2023

Choose a reason for hiding this comment

mfn commented May 12, 2023

sforward commented May 30, 2023

mfn commented Jun 4, 2023

Cache off, 100 iterations

Cache off, 1000 iterations

Cache on, 100 iterations

Cache on, 1000 iterations

🤷🏼

sforward commented Jul 1, 2023

mfn commented Jul 1, 2023

sforward commented Mar 21, 2023 •

edited

Loading