Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagination: enforce nonNull on the inner type as well as on the list #1033

Merged
merged 1 commit into from
May 29, 2023

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented May 12, 2023

Summary


Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn mfn self-assigned this May 12, 2023
@mfn mfn force-pushed the mfn-pageination-nonnull branch 3 times, most recently from 7c0b5e0 to bb4980a Compare May 29, 2023 14:43
@mfn mfn force-pushed the mfn-pageination-nonnull branch from bb4980a to 9e4f82d Compare May 29, 2023 14:46
@mfn mfn merged commit c55bbcd into master May 29, 2023
44 checks passed
@mfn mfn deleted the mfn-pageination-nonnull branch May 29, 2023 14:52
@99linesofcode
Copy link

@mfn it's good to see that this is merged. Will it be part of a new major release and if so, when do you expect that to ship?

@mfn
Copy link
Collaborator Author

mfn commented Jun 5, 2023

I want to put out an RC2 soon and hope to include #1008 for it too.

@mfn
Copy link
Collaborator Author

mfn commented Jun 18, 2023

#1008 is still a bit unclear, I've just put out 9.0.0-rc2.

The idea is to make the 9.0.0 stable release in a week latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NonNull type for data in pagination and NonNull ListOf type
2 participants