❗BREAKING CHANGE❗️ Remove optional support for non-lazy loading of types #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazy loading has been introduced in 2.0.0 (2019-08) and has been enabled by default in 8.0.0 (2021-11). From now on the type loader is always used when resolving types and the impact mostly means that you can't have types registered using an alias different from their name. As can be seen by th commit, this reduces complexity and maintenance overhead of the library.
mfn
force-pushed
the
mfn-remove-type-aliases
branch
from
38ee06d
to
2a1b3f5
Compare
tm1000
approved these changes
Jan 27, 2023
|
Let's merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lazy loading has been introduced in 2.0.0 (2019-08) and has been enabled by default in 8.0.0 (2021-11).
From now on the type loader is always used when resolving types and the impact mostly means that you can't have types registered using an alias different from their name.
As can be seen by th commit, this reduces complexity and maintenance overhead of the library.
Notes
I extracted this commit from #953 to make it more stand out and emphasize this was not a random change. But PR #953 won't be rebased to exclude it, so the history might look "a bit weird".
Type of change:
Checklist:
composer fix-style