-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch / PR to integrate all breaking changes for release 9 #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A later commit adds support back for our own error classes.
…y for our own error classes
The ability to internally prepend the graphql-php namespace was removed [1]. [1] webonyx/graphql-php@d36e809#diff-fa0403de31548d680d863a100fdc906ec53696abb9d1e8b0cbc92020b7cce9a2L255
Until we figure out what the replacement for the getter is
…ReadOnly` have been dropped in favour of the public properties
This reverts commit 86f2ded.
# Conflicts: # phpstan.neon.dist
Lazy loading has been introduced in 2.0.0 (2019-08) and has been enabled by default in 8.0.0 (2021-11). From now on the type loader is always used when resolving types and the impact mostly means that you can't have types registered using an alias different from their name. As can be seen by th commit, this reduces complexity and maintenance overhead of the library.
# Conflicts: # CHANGELOG.md # composer.json
Lazy loading has been introduced in 2.0.0 (2019-08) and has been enabled by default in 8.0.0 (2021-11). From now on the type loader is always used when resolving types and the impact mostly means that you can't have types registered using an alias different from their name. As can be seen by th commit, this reduces complexity and maintenance overhead of the library.
# Conflicts: # .github/workflows/tests.yml # CHANGELOG.md # composer.json # phpstan-baseline.neon # phpstan.neon.dist # tests/Unit/GraphQLTest.php
…n-integration-v9 # Conflicts: # .github/workflows/tests.yml # src/GraphQL.php
# Conflicts: # .github/workflows/integration_tests.yml # .github/workflows/tests.yml # composer.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This will integration all PRs mentioned in #969 to help me sort out potential merge issues before merging into master.
I'll keep a
8.x
branch already branched from master for some time so we can also release hotfixes for 8, if necessary.PRs included: