Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

❗BREAKING CHANGE❗️Remove support for Laravel 6 #967

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Conversation

mfn
Copy link
Collaborator

@mfn mfn commented Jan 7, 2023

Summary

L6 has been out of all support (bugs,security) since last year -> time to move on and remove support for it.


Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@mfn mfn self-assigned this Jan 7, 2023
@mfn mfn added this to the 9.0.0 milestone Jan 7, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@tm1000
Copy link
Contributor

tm1000 commented Feb 2, 2023

@mfn do you have an ETA for this PR? Just curious. No rush!

@mfn
Copy link
Collaborator Author

mfn commented Feb 2, 2023

Almost been a month 😱

I've pretty big private codebase with 5k+ GraphQL integration tests. Not that the test suite in this library is bad, but the other codebase also has quite an interesting coverage and it's challenging to get it working due to breaking changes (everyone hates them 😅).

My point is: I first want to make the private project work with this PR, to make sure I didn't miss anything. In the past it has been very valuable to make quite stable releases.

@tm1000
Copy link
Contributor

tm1000 commented Feb 3, 2023

Oh that's great! Appreciate your commitments to open source and stability within.

@websitevirtuoso
Copy link
Contributor

Thanks

@mfn
Copy link
Collaborator Author

mfn commented Mar 4, 2023

@mfn do you have an ETA for this PR? Just curious. No rush!

Still no ETA, but good news:

I've pretty big private codebase with 5k+ GraphQL integration tests. Not that the test suite in this library is bad, but the other codebase also has quite an interesting coverage and it's challenging to get it working due to breaking changes (everyone hates them 😅).

My point is: I first want to make the private project work with this PR, to make sure I didn't miss anything. In the past it has been very valuable to make quite stable releases.

I can confirm this code base passed all tests and therefore this is no blocker anymore.

There are still other things I need to check.

@mfn mfn merged commit 3ab820b into master Mar 5, 2023
@mfn mfn deleted the mfn-rm-l6 branch June 26, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants