Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 10 support #983

Merged
merged 5 commits into from
Feb 18, 2023
Merged

Laravel 10 support #983

merged 5 commits into from
Feb 18, 2023

Conversation

jasonvarga
Copy link
Contributor

Summary

This PR adds Laravel 10 support.

  • Updates dependencies
  • Updates GitHub Action workflows
  • The only failing tests had to do with validation strings, which have changed slightly in Laravel 10. I've updated the tests to use lang() helper instead of the strings

Only issue is code analysis:

PHPStan is now failing. This is a little over my head. I had to require v2 of larastan in order for Laravel 10 to be installable. I removed the phpstan explicit requirement so larastan can deal with that. Maybe that's why it's failing. Or maybe it has to do with all the typehints added to Laravel 10.

I noticed in this commit that you required explicit versions. Not sure of the story behind that.

From my end, this PR is done / ready for review. Let me know what you want done regarding Larastan/PHPStan.


Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@jasonvarga jasonvarga mentioned this pull request Feb 14, 2023
3 tasks
@mfn
Copy link
Collaborator

mfn commented Feb 15, 2023

Nice, thanks! Will try to get to it ASAP, but a bit busy this week

@jasonvarga
Copy link
Contributor Author

No worries. Thanks!

composer.json Show resolved Hide resolved
@mfn mfn mentioned this pull request Feb 18, 2023
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my suggested fix will be merged via #984

@mfn mfn merged commit 83ec9ed into rebing:master Feb 18, 2023
@mfn
Copy link
Collaborator

mfn commented Feb 18, 2023

@mfn mfn mentioned this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants