Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove psycopg2 dependency #75

Closed
criccomini opened this issue Jan 6, 2023 · 0 comments · Fixed by #77
Closed

Remove psycopg2 dependency #75

criccomini opened this issue Jan 6, 2023 · 0 comments · Fixed by #77
Assignees
@criccomini
Labels
bug Something isn't working

Comments

@criccomini
Copy link
Contributor

psycopg2 isn't needed out of the box anymore. I'm going to remove it. I will update the documentation to make a note that psycopg2 will need to be installed in order for SQLAlchemy, DatabaseBrowser, and the table analyzers to work with PostgreSQL.
@criccomini criccomini added the bug Something isn't working label Jan 6, 2023
@criccomini criccomini self-assigned this Jan 6, 2023
criccomini added a commit that referenced this issue Jan 6, 2023
@criccomini
Remove psycopg2 from dependencies
7333f43 
@abhiramr pointed out that those without PostgreSQL drivers on their machine
(specifically, libpq-dev) will have issues installing recap-core. PostgreSQL
isn't actually required for Recap; it was included for convenience. Since it's
causing problems, I'm going to remove it.

Users that wish to crawl PostgreSQL databases will now need to:

    pip install psycopg2

Closes #75
@criccomini criccomini mentioned this issue Jan 6, 2023
Merged
criccomini added a commit that referenced this issue Jan 6, 2023
@criccomini
Remove psycopg2 from dependencies
dddcc64 
@abhiramr pointed out that those without PostgreSQL drivers on their machine
(specifically, libpq-dev) will have issues installing recap-core. PostgreSQL
isn't actually required for Recap; it was included for convenience. Since it's
causing problems, I'm going to remove it.

Users that wish to crawl PostgreSQL databases will now need to:

    pip install psycopg2

Closes #75
criccomini added a commit that referenced this issue Jan 6, 2023
@criccomini
Bump to version 0.2.1
8f9cabf 
I'm getting ready to publish 0.2.1 because I want to get #75 out since it's
causing install problems.
@criccomini criccomini mentioned this issue Jan 6, 2023
Merged
criccomini added a commit that referenced this issue Jan 6, 2023
@criccomini
Bump to version 0.2.1
8129583 
I'm getting ready to publish 0.2.1 because I want to get #75 out since it's
causing install problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@criccomini criccomini

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove psycopg2 from dependencies gabledata/recap
1 participant
@criccomini