Renamed as_of to time #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks! You're the very first contributor!! 😄 |
criccomini
added a commit
that referenced
this pull request
Jan 22, 2023
This is a very minor follow-on fix to #130. I noticed the CLI still has `as-of` in a few spots; probably escaped the grep search.
criccomini
added a commit
that referenced
this pull request
Jan 22, 2023
This is a very minor follow-on fix to #130. I noticed the CLI still has `as-of` in a few spots; probably escaped the grep search.
criccomini
added a commit
that referenced
this pull request
Jan 22, 2023
This is a very minor follow-on fix to #130. I noticed the CLI still has `as-of` in a few spots; probably escaped the grep search.
|
Thanks, Happy to help! FYI, this was my first open source contribution as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @criccomini #128 request, Have renamed the
as_ofparameter name totimewhich seems more standard.