Prop domain is not default [0, "auto"] for <YAxis />
#3377
Comments
|
Yikes sorry, I might just revert the whole change rather than trying to fix it. Too many fragile pieces... |
|
Found the fix.. will address but going to take more time to add tests |
8 tasks
|
@nyanyani released fix in patch 2.4.3. Thanks for the report! |
ckifer
added a commit
that referenced
this issue
Feb 16, 2023
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Domain `[0, 'auto']` default broke because `originalDomain` was no longer set correctly - this was used by other functions of `generateCategoricalChart` especially when calculating `ticks` using `tickCount` ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> #3377 ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> Axis default broken in 2.4.0+ ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> * add some basic unit tests for generateCategoricalChart that would've prevented this breaking change ## Screenshots (if appropriate): Pre-Change (bug):  Post-Change (fixed):  ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have added tests to cover my changes. - [x] All new and existing tests passed. Co-authored-by: Coltin Kifer <ckifer@amazon.com>
scudette
added a commit
to Velocidex/velociraptor
that referenced
this issue
Apr 8, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade recharts
from 2.4.3 to 2.5.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **23 days ago**, on 2023-03-15.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>recharts</b></summary>
<ul>
<li>
<b>2.5.0</b> - <a
href="https://snyk.io/redirect/github/recharts/recharts/releases/tag/v2.5.0">2023-03-15</a></br><h2>What's
Changed</h2>
<h3>Feat</h3>
<ul>
<li><code>ResponsiveContainer</code>: <code>onResize</code> callback
function by <a class="user-mention notranslate"
data-hovercard-type="user" data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1582916569" data-permission-text="Title is private"
data-url="recharts/recharts#3361"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3361/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3361">#3361</a></li>
<li><code>XAxis</code>, <code>YAxis</code>: <code>includeHidden</code>
prop - include all datapoints in domain calculation even when hidden by
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/neefrehman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/neefrehman">@ neefrehman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1500101512" data-permission-text="Title is private"
data-url="recharts/recharts#3103"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3103/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3103">#3103</a></li>
<li><code>XAxis</code>, <code>YAxis</code>: new interval option
<code>equidistantPreserveStart</code> by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/nikolasrieble/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nikolasrieble">@ nikolasrieble</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1594785191" data-permission-text="Title is private"
data-url="recharts/recharts#3392"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3392/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3392">#3392</a></li>
</ul>
<h3>Fix</h3>
<ul>
<li><code>ResponsiveContainer</code>: default min-width to 0 to override
default auto behavior that breaks flexbox layouts by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1594523953" data-permission-text="Title is private"
data-url="recharts/recharts#3391"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3391/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3391">#3391</a></li>
<li><code>Area</code>: Add missing 'data' type to Area component by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ondrejvelisek/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ondrejvelisek">@ ondrejvelisek</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1615470205" data-permission-text="Title is private"
data-url="recharts/recharts#3443"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3443/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3443">#3443</a></li>
<li><code>Brush</code>/<code>XAxis</code>: fix NaN regression when
<code>interval={0}</code> by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/nikolasrieble/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nikolasrieble">@ nikolasrieble</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1622213441" data-permission-text="Title is private"
data-url="recharts/recharts#3454"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3454/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3454">#3454</a></li>
<li><code>ReferenceArea</code>/<code>ReferenceLine</code>: revert
regression where <code>ifOverflow</code> prop is not obeyed due to
missing defaultProps by <a class="user-mention notranslate"
data-hovercard-type="user" data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1622808868" data-permission-text="Title is private"
data-url="recharts/recharts#3455"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3455/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3455">#3455</a></li>
</ul>
<h3>Docs</h3>
<ul>
<li>lots of storybook changes - <a
href="https://master--63da8268a0da9970db6992aa.chromatic.com/"
rel="nofollow">go check it out</a>!</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li>chore: explicitly upgrade minor version of react-smooth by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1597775617" data-permission-text="Title is private"
data-url="recharts/recharts#3397"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3397/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3397">#3397</a></li>
<li>chore: upgrade react-resize-detector to 8.x by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1607429776" data-permission-text="Title is private"
data-url="recharts/recharts#3418"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3418/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3418">#3418</a></li>
</ul>
<h3>Refactor</h3>
<ul>
<li>Refactoring: Adapt getTicks to increase reusability of code by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/nikolasrieble/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nikolasrieble">@ nikolasrieble</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1595050186" data-permission-text="Title is private"
data-url="recharts/recharts#3393"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3393/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3393">#3393</a></li>
<li>Refactoring: Extract TicksUtils from CartesianAxis and add unit
tests by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/nikolasrieble/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nikolasrieble">@ nikolasrieble</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1593521268" data-permission-text="Title is private"
data-url="recharts/recharts#3386"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3386/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3386">#3386</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ondrejvelisek/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ondrejvelisek">@ ondrejvelisek</a>
made their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1615470205"
data-permission-text="Title is private"
data-url="recharts/recharts#3443"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3443/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3443">#3443</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/recharts/recharts/compare/v2.4.3...v2.5.0"><tt>v2.4.3...v2.5.0</tt></a></p>
</li>
<li>
<b>2.4.3</b> - <a
href="https://snyk.io/redirect/github/recharts/recharts/releases/tag/v2.4.3">2023-02-16</a></br><h2>v2.4.3</h2>
<p>cherry-picked commit <a class="commit-link"
data-hovercard-type="commit"
data-hovercard-url="https://github.com/recharts/recharts/commit/7925fd7d6e76812fe680df9844656feca21ebde9/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/commit/7925fd7d6e76812fe680df9844656feca21ebde9"><tt>7925fd7</tt></a>
to not pollute patch release with other changes</p>
<h3>fix</h3>
<ul>
<li>ensure <code>originalDomain</code> is defaulted if no domain is
provided - broke <code>tickCount</code> calculation - <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1587500881" data-permission-text="Title is private"
data-url="recharts/recharts#3377"
data-hovercard-type="issue"
data-hovercard-url="/recharts/recharts/issues/3377/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/issues/3377">#3377</a>
<ul>
<li>assign default to <code>originalDomain</code> for re-use in
generateCategoricalChart</li>
<li>add unit tests so this doesn't happen again</li>
</ul>
</li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/recharts/recharts/compare/v2.4.2...v2.4.3"><tt>v2.4.2...v2.4.3</tt></a></p>
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/recharts/recharts/releases">recharts
GitHub release notes</a>
</details>
</details>
<details>
<summary><b>Commit messages</b></summary>
</br>
<details>
<summary>Package name: <b>recharts</b></summary>
<ul>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/3e31520ce0a71dc48532f996900250396a135bcd">3e31520</a>
2.5.0</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/59b1389663698820c23d8638012af7b32ef23efc">59b1389</a>
chore(deps-dev): bump webpack from 5.75.0 to 5.76.0 (#3458)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/ef480490a81fa9497508feb10836c02769cec715">ef48049</a>
Storybook Examples: Add all ScatterChart examples from the website to
Storybook (#3456)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/230bad0c1b1c6e352451baeee3537deef474d576">230bad0</a>
Revert "Refactored: added default values in params for
ReferenceAreaand ReferenceLine since default props is deprecated
(#3455)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/9ce59d56f1b2bda131b32d68f40273df169e6bbe">9ce59d5</a>
fix(storybook): keep reference area within chart</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/4ee4124f3d73f9487b4b74d6aedac0f87af8d3a2">4ee4124</a>
ChartUtils: GetTicks only returns valid ticks that are part of the
current domain. (#3454)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/b1e7db8f3487301ee26e1ec37125d74796b4662e">b1e7db8</a>
fix: linechart storybook, add storybook types (#3451)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/b4a8c1a1a9377f09f46fa07dc0b97d7f4a18af8d">b4a8c1a</a>
Add missing 'data' type to Area component (#3443)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/d1fab30f0fce62a7f8ca26a7e936f81c2c325b37">d1fab30</a>
chore: upgrade react-resize-detector to 8.x (#3418)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/33ceeaf54d8583543124bf955fd7f14290d96e74">33ceeaf</a>
Storybook: Add all examples from the website for Area and Bar Chart
(#3440)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/0a6aa4f79c19bf4919a89c68d190f992d48894cb">0a6aa4f</a>
Storybook - Add all LineChart examples from the website (#3439)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/86c16b6c24803ec5cefe7bf17466045ce60457db">86c16b6</a>
Storybook: add Bar stories (#3435)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/8366f721dc4454a07780b948fe751d4bce2d33bd">8366f72</a>
LineStories: Simplify and unify (#3436)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/ecaa1821ea5193ad8b5eadb8fc24c143cefdc638">ecaa182</a>
Storybook: Create Welcome page (#3417)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/ac1911c12449d52fd60f897425a611374c0ab2b1">ac1911c</a>
Update CHANGELOG.md</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/d7bbda1570694a08178fa1104fa1523934f76e80">d7bbda1</a>
Storybook: Create a doc for Line with a Table of all args. (#3404)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/415a554af499fc71dc1b58322c786f526d9f4321">415a554</a>
fix: unify AreaChart stories data (#3411)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/1ab495aa02df764236e2623aafcd4305f1a3ce33">1ab495a</a>
docs(storybook): stockprice chart(candlestick) example (#3413)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/a8be8f2b72dcb04eaac19d15dde4282c5e18b980">a8be8f2</a>
refactor: pass data using args in PieChart (#3412)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/c72da1c5c3181bd9556a0051323546293ee6d8f7">c72da1c</a>
fix: unify line stories data (#3409)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/5dab4c733a4be4460fe5ba4f608991ad657b5ff0">5dab4c7</a>
fix: unify area stories data (#3408)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/82d3b799b9e9a22ab815f6258869123bf8ffc6ce">82d3b79</a>
Storybook: Extend guidance in README (#3402)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/36f2f879a7908d62b4e6552f1ee5570d145eafd8">36f2f87</a>
fix(storybook): remove composed chart wrapper container (#3405)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/dd5edee8ee526937efd5016a3288eea552b573a7">dd5edee</a>
Storybook: improve Area stories. (#3398)</li>
</ul>
<a
href="https://snyk.io/redirect/github/recharts/recharts/compare/0701fccae8de01c0ec1cd3f80bc5f6baef3511ba...3e31520ce0a71dc48532f996900250396a135bcd">Compare</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkZWY1MzU4ZC04MWI4LTQ0MzctODhhYS1iZTUxNTUzOTZjNTYiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImRlZjUzNThkLTgxYjgtNDQzNy04OGFhLWJlNTE1NTM5NmM1NiJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?pkg=recharts&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"def5358d-81b8-4437-88aa-be5155396c56","prPublicId":"def5358d-81b8-4437-88aa-be5155396c56","dependencies":[{"name":"recharts","from":"2.4.3","to":"2.5.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"76f4d127-566b-42ef-86f4-bdcbc92b90b4","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-03-15T21:53:23.231Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproduction link
Steps to reproduce
recharts@^2.4.0<YAxis tickCount={2} /><YAxis tickCount={2} domain={[0, "auto"]}/>What is expected?
Should behave like document said .
What is actually happening?
Omitted prop
domainbrokestickCountsince v2.4.0.The text was updated successfully, but these errors were encountered: